[WIP] feat: consolidate all YAML conditionals #891
Conversation
doc/schema/conditions.adoc
Outdated
| The "compatible with" operator will accept any version that is greater than or equal to the target and that has not been marked as a breaking version change in the database. | ||
| Note that RISC-V does not follow semantic versioning, so `2.0` may be compatible with `1.0` for a given extension as long as `2.0` (or any version between `1.0` and `2.0`) is not marked as a breaking version. |
There was a problem hiding this comment.
Is this "marking" documented somewhere?
If so, can you put a reference to that here?
doc/schema/conditions.adoc
Outdated
| | `less_than_or_equal` | Parameter value is less than or equal to | `less_than`: 5 | ||
| | `greater_than_or_equal` | Parameter value is greater than or equal to | `greater_than`: 5 |
There was a problem hiding this comment.
The examples here need to use the respective keys. (Looks like they were just copied from the previous examples.
doc/schema/conditions.adoc
Outdated
| Generic constraints provide an escape hatch when a condition is difficult to express when using <<ext_reqs,Extension Requirements>> or <<param_reqs,Parameter Requirements>>. | ||
| A generic constraint is an IDL function containing one or more link:../idl.adoc#implications[implications]. | ||
| The constraint holds if all the implications are true. | ||
| The constraint function does not return a value. |
There was a problem hiding this comment.
It seems more logical to return a boolean, no?
There was a problem hiding this comment.
We could, but the implications are easier to identify and extract as specific sub-conditions that apply. This becomes important so that we can transform between IDL <-> yaml forms of conditionals (I'll explain more in today's meeting)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
==========================================
- Coverage 46.05% 43.99% -2.07%
==========================================
Files 11 9 -2
Lines 4942 16283 +11341
Branches 1345 6051 +4706
==========================================
+ Hits 2276 7163 +4887
- Misses 2666 9120 +6454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WIP