Skip to content

fix(epoxy): fix sending msgs to self #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

fix(epoxy): fix sending msgs to self #2913

merged 1 commit into from
Sep 16, 2025
+151 −57

Conversation

MasterPtato
Copy link
Contributor

No description provided.

@MasterPtato MasterPtato mentioned this pull request Sep 13, 2025
Merged
@vercel Vercel
Copy link

vercel bot commented Sep 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-cloud Error Error Sep 16, 2025 9:41am
rivet-site Ready Ready Preview Comment Sep 16, 2025 9:41am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rivet-studio Ignored Ignored Preview Sep 16, 2025 9:41am

This was referenced Sep 13, 2025
Merged
Merged
Merged
Merged
Merged
@jog1t jog1t mentioned this pull request Sep 13, 2025
Merged
@MasterPtato MasterPtato mentioned this pull request Sep 13, 2025
Merged
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Sep 13, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato mentioned this pull request Sep 13, 2025
Merged
@claude Claude
Copy link

claude bot commented Sep 13, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 13, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner@2913

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner-protocol@2913

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-tunnel-protocol@2913

commit: 4f09c22

@MasterPtato MasterPtato marked this pull request as ready for review September 13, 2025 01:20
graphite-app[bot]
graphite-app bot reviewed Sep 13, 2025
View reviewed changes
packages/services/epoxy/src/workflows/replica/setup.rs
@@ -14,10 +15,10 @@ use crate::types;
// activities which can cause the learning process to enter an invalid state.

pub async fn setup_replica(ctx: &mut WorkflowCtx, _input: &super::Input) -> Result<()> {
// Wait for coordiinator to send begin learning signal
// Wait for cooridinator to send begin learning signal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the comment: cooridinator should be spelled coordinator.

Suggested change
// Wait for cooridinator to send begin learning signal
// Wait for coordinator to send begin learning signal

Spotted by Diamond

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

packages/services/epoxy/src/workflows/replica/setup.rs
let begin_learning = ctx.listen::<super::BeginLearning>().await?;

// TODO: Parallelize replicas
// TODO: Paralellize replicas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the comment: Paralellize should be spelled Parallelize.

Suggested change
// TODO: Paralellize replicas
// TODO: Parallelize replicas

Spotted by Diamond

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

@NathanFlurry NathanFlurry mentioned this pull request Sep 13, 2025
Merged
This was referenced Sep 13, 2025
Open
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@NathanFlurry NathanFlurry force-pushed the 09-12-fix_epoxy_fix_sending_msgs_to_self branch from e67a469 to 734f367 Compare September 14, 2025 20:00
@NathanFlurry NathanFlurry force-pushed the 09-12-fix_api_fix_query_serialization_for_remote_req branch from 808ae80 to 37b90b4 Compare September 14, 2025 20:00
@claude Claude
Copy link

claude bot commented Sep 14, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Sep 14, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry mentioned this pull request Sep 14, 2025
Merged
@jog1t jog1t force-pushed the 09-12-fix_epoxy_fix_sending_msgs_to_self branch from 734f367 to e67a469 Compare September 15, 2025 16:47
@jog1t jog1t force-pushed the 09-12-fix_api_fix_query_serialization_for_remote_req branch from 37b90b4 to 808ae80 Compare September 15, 2025 16:47
@claude Claude
Copy link

claude bot commented Sep 15, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t mentioned this pull request Sep 15, 2025
Closed
@claude Claude
Copy link

claude bot commented Sep 15, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato MasterPtato force-pushed the 09-12-fix_api_fix_query_serialization_for_remote_req branch from 808ae80 to 8de2534 Compare September 15, 2025 18:04
@MasterPtato MasterPtato force-pushed the 09-12-fix_epoxy_fix_sending_msgs_to_self branch from e67a469 to 4f09c22 Compare September 15, 2025 18:04
@claude Claude
Copy link

claude bot commented Sep 15, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Sep 15, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato MasterPtato mentioned this pull request Sep 15, 2025
Merged
@MasterPtato MasterPtato mentioned this pull request Sep 15, 2025
Merged
@NathanFlurry NathanFlurry force-pushed the 09-12-fix_api_fix_query_serialization_for_remote_req branch from 8de2534 to ae449e3 Compare September 16, 2025 08:15
Base automatically changed from 09-12-fix_api_fix_query_serialization_for_remote_req to main September 16, 2025 08:16
@NathanFlurry NathanFlurry force-pushed the 09-12-fix_epoxy_fix_sending_msgs_to_self branch from 4f09c22 to a191a45 Compare September 16, 2025 08:16
@NathanFlurry NathanFlurry merged commit eee75ee into main Sep 16, 2025
3 of 7 checks passed
@NathanFlurry NathanFlurry deleted the 09-12-fix_epoxy_fix_sending_msgs_to_self branch September 16, 2025 08:16
@claude Claude
Copy link

claude bot commented Sep 16, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@github-actions github-actions bot mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@NathanFlurry NathanFlurry Awaiting requested review from NathanFlurry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterPtato @NathanFlurry