-
Notifications
You must be signed in to change notification settings - Fork 141
Update examples to serverless format #3785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚅 Deployed to the rivet-pr-3785 environment in rivet-frontend
🚅 Environment rivet-pr-3785 in rivet-frontend-website-preview has no services deployed. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Pull Request Review: Update Examples to Serverless FormatOverviewThis PR implements a comprehensive migration of all examples from a development-focused structure to a production-ready serverless deployment format. The changes affect 228 files with ~2,355 additions and ~1,072 deletions. Summary of ChangesArchitectural Changes
Positive Aspects✅ Consistent Pattern: All examples follow the same architectural pattern Issues and Concerns🔴 Critical Issues1. Vite Build Output Path MismatchLocation: Multiple // vite.config.ts
build: {
outDir: "dist", // Outputs to frontend/dist
}
// package.json
"start": "srvx --static=../frontend/dist dist/server.js"The relative path Impact: Production deployments will fail to serve static assets Recommendation: Update the "start": "srvx --static=frontend/dist dist/server.js"This issue appears in most examples with frontend directories. 2. Inconsistent Static Path ReferencesLocation: Various Examples:
Recommendation: Standardize based on directory structure:
|
4eace34 to
50262cb
Compare
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
50262cb to
9754f1d
Compare
9754f1d to
12c3069
Compare
…stry.serve() Co-authored-by: jog1t <[email protected]>
Co-authored-by: jog1t <[email protected]>
Co-authored-by: jog1t <[email protected]>
…h start scripts Co-authored-by: jog1t <[email protected]>
Co-authored-by: jog1t <[email protected]>
…atic serving Co-authored-by: jog1t <[email protected]>
…implify scripts Co-authored-by: jog1t <[email protected]>
12c3069 to
037000e
Compare
Merge activity
|

No description provided.