chore(example): update examples to use srvx

[NathanFlurry]

No description provided.

[railway-app]

🚅 Deployed to the rivet-pr-3790 environment in rivet-frontend

Service	Status	Web	Updated (UTC)
website	😴 Sleeping (View Logs)	Web	Jan 8, 2026 at 11:20 pm
frontend-cloud-prod	😴 Sleeping (View Logs)	Web	Jan 8, 2026 at 11:03 pm
frontend-cloud-staging	😴 Sleeping (View Logs)	Web	Jan 8, 2026 at 11:01 pm
frontend-inspector	😴 Sleeping (View Logs)	Web	Jan 8, 2026 at 11:01 pm

---

🚅 Deployed to the rivet-pr-3790 environment in rivet-frontend-website-preview

Service	Status	Web	Updated (UTC)
frontend-cloud	❌ Build Failed (View Logs)	Web	Jan 8, 2026 at 1:03 am
website	❌ Build Failed (View Logs)	Web	Jan 8, 2026 at 1:03 am

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(examples): update examples to standardized format #3799
• chore(example): update examples to use srvx #3790 👈 (View in Graphite)
• chore(examples): add node server dependency #3788
• Update examples to serverless format #3785
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Pull Request Review: Update examples to use srvx

This PR migrates the chat-room example from a dual dev server setup (separate frontend/backend) to a unified development experience using vite-plugin-srvx, and adds comprehensive documentation for example structure. Overall, this is a solid improvement that simplifies the developer experience. Here are my findings:

---

✅ Strengths

1. Excellent Documentation

The new examples/CLAUDE.md is comprehensive and well-structured:

• Clear patterns for three different example types (unified vite-plugin-srvx, separate dev servers, backend-only)
• Complete configuration templates for all necessary files
• Good code examples with explanatory comments
• Helpful TODO section tracking known issues across examples

2. Simplified Development Experience

The migration to vite-plugin-srvx greatly improves DX:

• Single npm run dev command instead of concurrently running two servers
• No manual proxy configuration needed
• Cleaner dependency tree (removed tsup, concurrently, prompts)
• Removed unused CLI script (scripts/cli.ts)

3. Correct Dynamic API URL

examples/chat-room/frontend/App.tsx:5 - Changed from hardcoded http://localhost:5173/api/rivet to ${location.origin}/api/rivet which is more robust for different deployment environments.

---

⚠️ Issues to Address

1. Dependency Misplacement (Priority: Medium)

examples/chat-room/package.json:13-33

According to the new documentation (examples/CLAUDE.md:151), srvx should be in dependencies (not devDependencies) since it is used by the start script for production.

Current:

"devDependencies": {
  ...
},
"dependencies": {
  "srvx": "^0.10.0"
}

This is actually correct ✅ - the change was made properly in this PR.

However, concurrently is still in devDependencies but is no longer used and should be removed per the documentation (examples/CLAUDE.md:406).

2. TODO Comment Without Context (Priority: Low)

rivetkit-typescript/packages/rivetkit/src/registry/serve.ts:6-8,19-20

// TODO: Go back to dynamic import for this
import getPort from 'get-port';

// TODO: Fix this
// const getPortModule = "get-port";

These TODO comments lack context about why dynamic imports are preferred or what needs fixing. Consider:

• Why was dynamic import originally used? (Probably webpack/bundler compatibility)
• What breaks with static imports?
• Is there a tracking issue?

Recommendation: Add more context or create a GitHub issue and reference it.

3. Incomplete Example Cleanup (Priority: Low)

The PR adds a TODO list in examples/CLAUDE.md:398-409 but does not fully address all items for the chat-room example:

• ✅ Removed scripts/ directory
• ✅ Removed tsup.config.ts
• ✅ Removed prompts dependencies
• ✅ Moved srvx to dependencies
• ❌ concurrently is still in devDependencies (line 20) but unused

---

🔍 Code Quality Observations

Good Practices Followed:

1. ✅ Using location.origin for dynamic API URLs
2. ✅ Proper package.json script ordering
3. ✅ Consistent use of vite-plugin-srvx pattern
4. ✅ Documentation matches implementation

Minor Style Notes:

1. rivetkit-typescript/packages/rivetkit/package.json:168-183 - Dependencies were alphabetically sorted, which is good for maintainability
2. The index.html move from frontend/index.html to root is correct for vite-plugin-srvx pattern

---

🛡️ Security & Performance

• ✅ No security concerns identified
• ✅ No performance regressions expected
• ✅ The unified dev server should actually improve development performance by eliminating proxy overhead

---

🧪 Testing

The PR does not modify test files, which is appropriate since the functionality remains the same, only the build/dev setup changed. However:

Recommendation: Manually verify that:

1. npm run dev works correctly
2. npm run build produces correct output
3. npm run start serves the built app properly
4. npm run test still passes

---

📋 Recommendations

Must Fix:

1. Remove unused concurrently from devDependencies in examples/chat-room/package.json

Should Fix:

2. Improve TODO comments in serve.ts with context or issue links

Nice to Have:

3. Apply these same updates to other examples in the repository (as outlined in the TODO list)

---

Summary

This is a well-executed refactor that meaningfully improves the developer experience. The addition of comprehensive documentation is particularly valuable. The main issue is the leftover concurrently dependency, which should be removed to keep dependencies clean.

Overall Assessment: ✅ Approve with minor changes requested

Once concurrently is removed from devDependencies, this PR is ready to merge.

[claude]

Pull Request Review: chore(example): update examples to use srvx

This PR successfully migrates the chat-room example to use the unified vite-plugin-srvx pattern, simplifying the development setup and improving cross-platform compatibility. The changes align well with the repository's standards and the new examples/CLAUDE.md guidelines.

✅ Strengths

1. Excellent Documentation: The new examples/CLAUDE.md and rivetkit-typescript/contrib-docs/EXAMPLE_PROJECT_STRUCTURE.md provide comprehensive guidelines that will significantly help maintainability and consistency across examples.

2. Simplified Development Workflow: Moving from separate frontend/backend dev servers to a unified Vite dev server with vite-plugin-srvx is a clear improvement in DX.

3. ESM Compliance: Adding .ts extensions to imports (from "./actors.ts") with the tsconfig options allowImportingTsExtensions and rewriteRelativeImportExtensions properly aligns with modern ESM standards.

4. Dependency Organization: Correctly moved runtime dependencies (srvx, @hono/node-server, @hono/node-ws) from devDependencies to dependencies since they're used by the start script.

5. Clean Removal: Appropriately removed unused CLI client code (scripts/cli.ts) and related dependencies (prompts, @types/prompts).

6. WinterTC Pattern: The new server.ts properly exports a Hono app as default export, which works across Vercel, Node, Bun, and Deno.

⚠️ Issues Found

1. Unused devDependency: concurrently

Location: examples/chat-room/package.json:18

"concurrently": "^8.2.2",

Issue: The concurrently package is no longer needed since the example now uses a unified dev server instead of separate frontend/backend dev servers. This is explicitly mentioned in the TODO checklist at line 456 of examples/CLAUDE.md.

Fix: Remove this line from devDependencies.

---

2. Missing vercel.json Configuration

Issue: According to the new documentation (examples/CLAUDE.md:243-260 and rivetkit-typescript/contrib-docs/EXAMPLE_PROJECT_STRUCTURE.md:73-84), examples need a vercel.json file to explicitly set the framework to "hono" because Vercel auto-detects Vite and ignores Hono.

Expected file: examples/chat-room/vercel.json

{
  "framework": "hono"
}

Impact: Without this, the example won't deploy correctly on Vercel. The server won't have WinterTC support enabled.

---

3. Potential Build Output Issue

Location: Build configuration

Issue: The index.html was moved to the root, which is correct for Vite during development. However, verify that the build output directory matches what the start script expects.

The build script:

"build": "vite build && vite build --mode server"

The start script expects:

"start": "srvx --static=public/ dist/server.js"

Recommendation: Verify that Vite's build outputs static files to public/ or update the start script to match the actual build output directory (typically dist/).

---

📋 Minor Observations

1. tsconfig.json Simplification: The cleanup from 43 lines to 16 lines while maintaining strict type checking is excellent. The removal of redundant commented-out options improves readability.

2. Test File Updates: The test file correctly updated imports to use .ts extensions (../src/actors.ts).

3. Dynamic API Origin: Using location.origin in App.tsx is correct and ensures compatibility across deployment environments.

🎯 Recommendations

1. Add vercel.json to the chat-room example (critical for Vercel deployments)
2. Remove concurrently from devDependencies (cleanup)
3. Verify build output paths match the start script expectations
4. Consider applying these changes to other examples as mentioned in the TODO checklist

📊 Test Coverage

No test changes were needed beyond updating imports, which is appropriate. The existing test patterns remain valid.

🔒 Security

No security concerns identified. The changes don't introduce any vulnerabilities.

⚡ Performance

No performance concerns. The unified dev server should actually improve cold start times during development.

---

Summary

This is a solid refactoring that modernizes the example structure. The main issues to address are:

1. Missing vercel.json (will break Vercel deployments)
2. Leftover concurrently dependency (minor cleanup)
3. Verify build output configuration

Once these are addressed, this PR will provide an excellent foundation for migrating the remaining examples to the srvx pattern.