-
Notifications
You must be signed in to change notification settings - Fork 141
chore(examples): update examples to standardized format #3799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚅 Deployed to the rivet-pr-3799 environment in rivet-frontend
🚅 Deployed to the rivet-pr-3799 environment in rivet-frontend-website-preview
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: #3799 - Update examples to standardized formatOverviewThis PR implements a comprehensive standardization effort across all examples in the repository. The changes are primarily structural and configurational, establishing consistent patterns for project structure, configuration files, naming conventions, and documentation. Overall Assessment: ✅ Approve with minor suggestions This is excellent work that will significantly improve the maintainability and consistency of the examples. The standardization is thorough and well-documented. Key Strengths1. Comprehensive Documentation ✅
2. Consistent Configuration ✅
3. File Naming Convention ✅
4. Build & Dev Scripts Standardization ✅
5. Cleanup ✅
Issues Found🔴 Critical: Inconsistent Package NamingLocation: Multiple Issue: Package names are inconsistent. Some use
Expected: All examples should follow Recommendation: # These should be renamed in their package.json files:
"actor-actions" → "example-actor-actions"
"chat-room" → "example-chat-room"
"cursors" → "example-cursors"
"cursors-raw-websocket" → "example-cursors-raw-websocket"
"cross-actor-actions" → "example-cross-actor-actions"
# etc.Files to fix:
|
5f085e1 to
25754c1
Compare
7aef9d4 to
734bcaf
Compare
25754c1 to
3b2a559
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
3b2a559 to
a980ea9
Compare
734bcaf to
398d4a6
Compare
Merge activity
|

No description provided.