-
Notifications
You must be signed in to change notification settings - Fork 402
Resort members of InterfaceInfo to avoid ABI break #3001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikishor
approved these changes
Jan 29, 2026
Member
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3001 +/- ##
=======================================
Coverage 89.40% 89.40%
=======================================
Files 157 157
Lines 18781 18781
Branches 1510 1510
=======================================
Hits 16791 16791
Misses 1369 1369
Partials 621 621
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
(cherry picked from commit b59bd9c)
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
(cherry picked from commit b59bd9c)
christophfroehlich
pushed a commit
that referenced
this pull request
Jan 29, 2026
christophfroehlich
pushed a commit
that referenced
this pull request
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-jazzy
Triggers PR backport to ROS 2 jazzy.
backport-kilted
Triggers PR backport to ROS 2 kilted.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2997 (comment)
InterfaceInfois only passed inside a std::vector (its size does not change when the object changes). But the memory layout of the struct changes and accessing it will break. By moving the new member at the end of the struct, this should not be a problem.