Skip to content

Conversation

@christophfroehlich
Copy link
Member

@christophfroehlich christophfroehlich commented Jan 29, 2026

#2997 (comment)

InterfaceInfo is only passed inside a std::vector (its size does not change when the object changes). But the memory layout of the struct changes and accessing it will break. By moving the new member at the end of the struct, this should not be a problem.

Copy link
Member

@saikishor saikishor left a comment

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.40%. Comparing base (44cbd9c) to head (d2a193b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3001   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files         157      157           
  Lines       18781    18781           
  Branches     1510     1510           
=======================================
  Hits        16791    16791           
  Misses       1369     1369           
  Partials      621      621           
Flag Coverage Δ
unittests 89.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rface/include/hardware_interface/hardware_info.hpp 98.78% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Jan 29, 2026
@christophfroehlich christophfroehlich merged commit b59bd9c into master Jan 29, 2026
21 of 23 checks passed
@christophfroehlich christophfroehlich deleted the fix/abi/InterfaceInfo branch January 29, 2026 21:10
mergify bot pushed a commit that referenced this pull request Jan 29, 2026
mergify bot pushed a commit that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants