Change interface export variant#396
Merged
christophfroehlich merged 6 commits intoros-controls:masterfrom Oct 8, 2024
Merged
Conversation
4823232 to
d982069
Compare
d982069 to
e1ebe6b
Compare
1 task
christophfroehlich
approved these changes
Sep 26, 2024
Member
christophfroehlich
left a comment
There was a problem hiding this comment.
Tested and looks good! @mamueluth could you merge master into your fork pls?
destogl
approved these changes
Oct 8, 2024
Member
|
Rolling semi-binary and binary testing fail because of an issue while installing ros-rolling-gz-sim, binary main builds fail until the next sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This showcases for example 1 how the changes proposed in this PR would affect the hardware. The adjusted example has been tested and works with the changes. If you want to test them, first checkout the branch from the before mentioned PR.
The changes are described in more detail in the PR:
export_state_interfaces()andexport_command_interfaces()in the HWset_state/get_stateandset_commad/get_commandmethods to update states/read commands in the HW. Can either be used by passing theInterfaceDescriptionorstate_interface-/command_interface-nameIf you want to test:
change_interface_export_variantbranch from this PR