Replace RCLCPP_*_STREAM macros with RCLCPP_*

[Vedant87]

Closes issue #337

[christophfroehlich]

Thanks for your contribution.

However, please install pre-commit beforehand so that you get the errors at the time of the commit. Now you can fix them by running pre-commit run --all.

Can I ask you to also change the RCLCPP_INFO_STREAM methods, not only the ERROR log level?

[Vedant87]

Thanks for your contribution.

However, please install pre-commit beforehand so that you get the errors at the time of the commit. Now you can fix them by running pre-commit run --all.

Can I ask you to also change the RCLCPP_INFO_STREAM methods, not only the ERROR log level?

Sure, I can work on changing the RCLCPP_INFO_STREAM methods should I open a new PR or add the commits in this PR itself.

[christophfroehlich]

Please do in the same PR, and ensure that the code builds successfully before you push.

   /home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/src/ros2_controllers/parallel_gripper_controller/include/parallel_gripper_controller/parallel_gripper_action_controller_impl.hpp:263:5: error: ‘CLCPP_ERROR’ was not declared in this scope; did you mean ‘RCLCPP_ERROR’?
    263 |     CLCPP_ERROR(
        |     ^~~~~~~~~~~
        |     RCLCPP_ERROR

[codecov]

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (ac35696) to head (73863b1).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...per_controllers/gripper_action_controller_impl.hpp	0.00%	5 Missing ⚠️
...roller/parallel_gripper_action_controller_impl.hpp	0.00%	5 Missing ⚠️
...dmittance_controller/src/admittance_controller.cpp	0.00%	1 Missing ⚠️
...nt_trajectory_controller/interpolation_methods.hpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1600      +/-   ##
==========================================
+ Coverage   85.08%   85.09%   +0.01%     
==========================================
  Files         123      123              
  Lines       11703    11701       -2     
  Branches      999      997       -2     
==========================================
  Hits         9957     9957              
  Misses       1430     1430              
+ Partials      316      314       -2     

Flag	Coverage Δ
unittests	85.09% <20.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...include/joint_trajectory_controller/tolerances.hpp	79.79% <100.00%> (ø)
...dmittance_controller/src/admittance_controller.cpp	76.17% <0.00%> (ø)
...nt_trajectory_controller/interpolation_methods.hpp	55.55% <0.00%> (ø)
...per_controllers/gripper_action_controller_impl.hpp	32.11% <0.00%> (ø)
...roller/parallel_gripper_action_controller_impl.hpp	29.76% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[christophfroehlich]

Thanks!

[saikishor]

Looks good :)

[bmagyar]

Thank you!!