Skip to content

Conversation

@mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented May 5, 2025

fix compile alfter ros2/geometry2#752

FIX:
fatal error: tf2/LinearMath/Quaternion.h: No such file or directory
29 | #include "tf2/LinearMath/Quaternion.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

fix compile alfter ros2/geometry2#752
FIX:
fatal error: tf2/LinearMath/Quaternion.h: No such file or directory
   29 | #include "tf2/LinearMath/Quaternion.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (5eb04da) to head (2787703).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1675   +/-   ##
=======================================
  Coverage   84.79%   84.79%           
=======================================
  Files         127      127           
  Lines       12114    12114           
  Branches     1036     1036           
=======================================
  Hits        10272    10272           
  Misses       1503     1503           
  Partials      339      339           
Flag Coverage Δ
unittests 84.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...iff_drive_controller/src/diff_drive_controller.cpp 75.07% <ø> (ø)
..._drive_controller/src/mecanum_drive_controller.cpp 90.72% <ø> (ø)
mecanum_drive_controller/src/odometry.cpp 100.00% <ø> (ø)
tricycle_controller/src/tricycle_controller.cpp 66.80% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify
Copy link
Contributor

mergify bot commented May 5, 2025

This pull request is in conflict. Could you fix it @mosfet80?

@bmagyar
Copy link
Member

bmagyar commented May 5, 2025

I've just merged #1325 addressing the same. Could you please verify against the latest master?

@mosfet80 mosfet80 closed this May 6, 2025
@mosfet80 mosfet80 deleted the fix_TF2_deprecation branch May 6, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants