Change the tests to work without deprecated PID settings#1824
Merged
christophfroehlich merged 4 commits intomasterfrom Jul 22, 2025
Merged
Change the tests to work without deprecated PID settings#1824christophfroehlich merged 4 commits intomasterfrom
christophfroehlich merged 4 commits intomasterfrom
Conversation
github-actions
Bot
requested review from
LukasMacha97,
aprotyas,
arne48,
bmagyar,
destogl,
mhubii and
qiayuanl
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1824 +/- ##
=======================================
Coverage 85.66% 85.66%
=======================================
Files 123 123
Lines 12408 12406 -2
Branches 1056 1055 -1
=======================================
- Hits 10629 10628 -1
Misses 1430 1430
+ Partials 349 348 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
approved these changes
Jul 22, 2025
mergify Bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
(cherry picked from commit bf253f1) # Conflicts: # pid_controller/test/test_pid_controller.cpp # pid_controller/test/test_pid_controller.hpp # pid_controller/test/test_pid_controller_dual_interface.cpp
christophfroehlich
pushed a commit
that referenced
this pull request
Jul 22, 2025
greencookie-afk
pushed a commit
to greencookie-afk/ros2_controllers
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per title. I had to fix some test criteria as the integral action is not added at the first update call (integration is done after calculating the command).
needs ros-controls/control_toolbox#432