Fix open_loop odometry of steering controllers #2087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-jazzy
github-actions
bot
requested review from
Juliaj,
MarqRazz,
Maverobot,
destogl and
homalozoa
9 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2087 +/- ##
=======================================
Coverage 84.79% 84.79%
=======================================
Files 151 151
Lines 14605 14607 +2
Branches 1266 1266
=======================================
+ Hits 12384 12386 +2
Misses 1763 1763
Partials 458 458
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2025
(cherry picked from commit 441f2b2)
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2025
(cherry picked from commit 441f2b2)
christophfroehlich
pushed a commit
that referenced
this pull request
Dec 31, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that I accidentally removed that with #1721
This still has some issues if we hit the timeout, as the odometry will be updated from NaNs. This should be fixed with #2083 and proper tests to be added.