Add noble-testing to enable kilted beta use#82
Merged
emersonknapp merged 4 commits intomainfrom May 1, 2025
Merged
Conversation
emersonknapp
requested review from
MichaelOrlov and
christophebedard
and removed request for
a team
emersonknapp
force-pushed
the
emerson/noble-testing
branch
2 times, most recently
from
eb6e940 to
8ef996f
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
force-pushed
the
emerson/noble-testing
branch
from
d87fa40 to
267c392
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
christophebedard
approved these changes
May 1, 2025
Member
christophebedard
left a comment
christophebedard
left a comment
There was a problem hiding this comment.
The new names for the matrix variables are a bit confusing, but LGTM.
Member
|
Huh, should this have also added Kilted to the variant images? Also, CI is failing on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.