fix: blocklist duplicate typesupport extern declarations #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add blocklist patterns to generate_bindings.py to prevent bindgen from generating typesupport function declarations that clash with vendored message crates (rosidl_generator_rs generates these with *const c_void). Remove existing duplicate extern declarations from all 4 generated binding files for: - rosidl_typesupport_c__get_message_type_support_handle__action_msgs__* - rosidl_typesupport_c__get_service_type_support_handle__action_msgs__* Also fix clippy useless_vec warning in build.rs. Closes ros2-rust#559
esteve
force-pushed
the
fix/clashing-extern-declarations
branch
from
6b7d897 to
9b7cab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add blocklist patterns to generate_bindings.py to prevent bindgen from generating typesupport function declarations that clash with vendored message crates (rosidl_generator_rs generates these with *const c_void).
Remove existing duplicate extern declarations from all 4 generated binding files for:
Also fix clippy useless_vec warning in build.rs.
Closes #559