ros2node: Add verb get_type_description (rep2011)
#817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
achim-k
force-pushed
the
achim-k/rep2011_node_get_type_description
branch
from
6e738a5 to
7c11d7b
Compare
achim-k
commented
Apr 11, 2023
clalancette
previously requested changes
Apr 11, 2023
Adds the verb `get_type_description` which calls the given node's ~/get_type_description service and prints out the response. This verb is basically a shorthand for `ros2 service call <node>/get_type_description ...`. Signed-off-by: Hans-Joachim Krauch <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Hans-Joachim Krauch <[email protected]>
achim-k
force-pushed
the
achim-k/rep2011_node_get_type_description
branch
from
74690ee to
367e6b3
Compare
clalancette
reviewed
Jun 8, 2023
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
This generally looks good to me, but I'm going to hold off on approving until we finish ros2/rcl#1052 .
Contributor
Author
|
Closing, this will be implemented in #846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ros2/ros2#1159
Adds the verb
get_type_descriptionwhich calls the given node's~/get_type_descriptionservice (if available) and prints out the response. This verb is basically a shorthand forros2 service call <node>/get_type_description