Skip to content

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Aug 7, 2025

Previously, users were getting warnings for including merge commits to PRs that mentioned only @rustbot (Example). Now it has to have at least one human mentioned in order to trigger a comment.

@blyxyas blyxyas force-pushed the no-notify-on-triagebot-pings branch from ebe030e to 66da374 Compare August 7, 2025 17:49
@Urgau
Copy link
Member

Urgau commented Aug 7, 2025

A more principal fix would be to ignore subtree syncs, probably by adding a config on [no-mentions] (à la exclude-titles = ["subtree update"]).

Would you be willing to implement this instead? I can provide guidance. If not, that's okay, we can merge this PR in the meantime.

@blyxyas
Copy link
Member Author

blyxyas commented Aug 11, 2025

Yes I'd be willing to implement such a change, triagebot is a project I like working on.

Although I'm not sure how many titles that aren't subtree syncs (and thus, contain merge commits mentioning rustbot) would benefit from disabling the no-mentions check.

@Urgau
Copy link
Member

Urgau commented Aug 11, 2025

I proposed title based exclusion because that's what we currently do for the [no-merges] handler (example in r-l/r) and I think we are kind-of forced to do it for subtrees.

I don't think only excluding rustbot would work for subtrees, as merge commits often contain the complete description which can contain arbitrary mentions, which I don't think you would want them to be warn either.

As for other PRs that aren't subtree sync, we may still want to exclude rustbot (and maybe bors as well), although the usefulness of not linting for those PRs is less clear to me.

Allow ignoring some pull requests such as subtree updates,
as they don't benefit from a no-mentions warning.
@blyxyas blyxyas force-pushed the no-notify-on-triagebot-pings branch from 66da374 to 042a6be Compare August 16, 2025 19:03
@blyxyas blyxyas changed the title Do not notify if only rustbot is pinged in a commit message Add exclude-titles option to no-mentions Aug 16, 2025
@blyxyas
Copy link
Member Author

blyxyas commented Aug 16, 2025

Done! I've reoriented the pull request and added support for a new exclude_titles = ["..."] config opt.

Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two nits and we should be good to go.

@blyxyas blyxyas force-pushed the no-notify-on-triagebot-pings branch from 6e2f821 to ce67228 Compare August 17, 2025 16:30
@blyxyas blyxyas force-pushed the no-notify-on-triagebot-pings branch from ce67228 to cb79f88 Compare August 17, 2025 19:55
Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Let's ship it.

@Urgau Urgau added this pull request to the merge queue Aug 17, 2025
Merged via the queue into rust-lang:master with commit bfc7964 Aug 17, 2025
3 checks passed
@blyxyas blyxyas deleted the no-notify-on-triagebot-pings branch August 17, 2025 22:34
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 18, 2025
triagebot: Don't warn no-mentions on subtree updates

Complement to rust-lang/triagebot#2137

r? `@Urgau`
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 18, 2025
triagebot: Don't warn no-mentions on subtree updates

Complement to rust-lang/triagebot#2137

r? ``@Urgau``
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 19, 2025
triagebot: Don't warn no-mentions on subtree updates

Complement to rust-lang/triagebot#2137

r? `@Urgau`
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 19, 2025
triagebot: Don't warn no-mentions on subtree updates

Complement to rust-lang/triagebot#2137

r? ``@Urgau``
@Urgau
Copy link
Member

Urgau commented Aug 19, 2025

@blyxyas Forgot to ask, would you be up sending a PR updating the documentation of [no-mentions] in the forge? https://github.com/rust-lang/rust-forge/blob/master/src/triagebot/no-mentions.md

rust-timer added a commit to rust-lang/rust that referenced this pull request Aug 20, 2025
Rollup merge of #145542 - blyxyas:no-mentions-subtree, r=Urgau

triagebot: Don't warn no-mentions on subtree updates

Complement to rust-lang/triagebot#2137

r? ``@Urgau``
@blyxyas
Copy link
Member Author

blyxyas commented Aug 20, 2025

Yeah, of course! I'll open it ASAP

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 25, 2025
triagebot: Don't warn no-mentions on subtree updates

Complement to rust-lang/triagebot#2137

r? ``@Urgau``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants