Adjust purity of trait with lazy member #23788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/23245-missing-outer-separate-comp
branch
from
8d9c75f to
32cb403
Compare
|
Also fixes #23863 (the minimization is basically the same) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23245
jchyb:
Previously, the behavior for setting
NoInitsandPureInterfaceflags for class symbols inTreeInfo.defKind(when compiling from a source) and inTreeUnpickler(when reading Tasty) was inconsistent. This was problematic, as thePureInterfaceflag dictated whether outer accessors were generated inExplicitOuterphase (in theneedsOuterIfReferencedmethod), so in the issue minimization, the inherited trait would have the outer accessors defined, and the inheriting object would then not implement them. This led to runtimeMethodNotFounderrors.The problem was specifically with lazy vals, which were treated as if they did not have an rhs.