Fix error handling for one-phase commit

[brfrn169]

Description

This PR fixes error handling for one-phase commit.

Related issues and/or PRs

N/A

Changes made

Added an inline comment. Please take a look for the details.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Fixed a bug where a CommitException was thrown when committing a transaction, even though the transaction was actually committed.

[gemini-code-assist]

Summary of Changes

Hello @brfrn169, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the error handling mechanism for one-phase commit operations within the transaction consensus commit module. The primary goal is to provide more specific and accurate exception types when underlying execution failures occur, particularly when the transaction's status becomes unknown, thereby improving the robustness and clarity of error propagation.

Highlights

• Error Handling Refinement: The onePhaseCommitRecords method in CommitHandler now throws UnknownTransactionStatusException instead of the more general CommitException when an ExecutionException occurs during the commit process. This provides a more precise indication of the transaction's state.
• Method Signature Update: The onePhaseCommitRecords method's signature was updated to explicitly declare CommitConflictException and UnknownTransactionStatusException in its throws clause, replacing the broader CommitException.
• Comprehensive Test Updates: Corresponding unit tests in CommitHandlerTest and CommitHandlerWithGroupCommitTest were updated. This includes modifying test method signatures, renaming tests, and adjusting assertions to validate the correct propagation and handling of the new UnknownTransactionStatusException.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

Fix error handling in one-phase commit by replacing CommitException with UnknownTransactionStatusException when an ExecutionException occurs, and updating corresponding tests.

• Updated onePhaseCommitRecords to throw UnknownTransactionStatusException on execution failures.
• Adjusted tests in both CommitHandlerTest and CommitHandlerWithGroupCommitTest to expect the new exception type.
• Renamed disabled test methods to reflect UnknownTransactionStatusException.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
core/src/main/java/com/scalar/db/transaction/consensuscommit/CommitHandler.java	Changed onePhaseCommitRecords signature and exception type for ExecutionException.
core/src/test/java/com/scalar/db/transaction/consensuscommit/CommitHandlerTest.java	Updated expected exception in tests and adjusted throws clauses.
core/src/test/java/com/scalar/db/transaction/consensuscommit/CommitHandlerWithGroupCommitTest.java	Renamed disabled tests to use UnknownTransactionStatusException.

Comments suppressed due to low confidence (3)

core/src/test/java/com/scalar/db/transaction/consensuscommit/CommitHandlerWithGroupCommitTest.java:257

• [nitpick] The method signature is split across two lines, which can hinder readability. Consider combining the return type, method name, and parameters into a single line.

  public void

core/src/test/java/com/scalar/db/transaction/consensuscommit/CommitHandlerWithGroupCommitTest.java:268

• [nitpick] Similar to above, this method signature is broken into multiple lines. Merging it into one line will improve consistency and readability.

  public void

core/src/test/java/com/scalar/db/transaction/consensuscommit/CommitHandlerTest.java:1134

• [nitpick] This test method signature is split across lines; consider consolidating it into a single declaration for clarity.

  public void

[gemini-code-assist]

Code Review

This pull request refactors the error handling for one-phase commits by throwing a more specific UnknownTransactionStatusException instead of a generic CommitException when an ExecutionException occurs. The test changes reflect the new behavior.

[feeblefakie]

LGTM! Thank you!

BTW, did you find the issue from some tests? (I'm just wondering how you found it.)

[brfrn169]

BTW, did you find the issue from some tests? (I'm just wondering how you found it.)

@feeblefakie I encountered this issue during the Jepsen test, where the process would sometimes get stuck in the analysis phase. Initially, I suspected it was caused by higher memory usage compared to other tests, so we reduced the test duration and increased the heap size. This seemed to mitigate the issue at first; however, it reappeared in a subsequent daily Jepsen test run. Upon further investigation, I identified the underlying bug.

[komamitsu]

LGTM! 👍

[Torch3333]

LGTM, thank you!