refactor: join the app selector and team selector logic #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeg
added
code health
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 62.94% 62.97% +0.02%
==========================================
Files 212 212
Lines 21643 21592 -51
==========================================
- Hits 13624 13597 -27
+ Misses 6965 6950 -15
+ Partials 1054 1045 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
This was referenced Jul 17, 2025
mwbrooks
approved these changes
Jul 21, 2025
| // as team domain is not guaranteed to be unique | ||
| func (ac *AppClient) getDeployedAppTeamDomain(ctx context.Context) string { | ||
| // Find the app team using the priority: | ||
| // 1. Team Flag (set by the user or prompts.TeamAppSelectPrompt) |
|
|
||
| // TeamAppSelectPrompt prompts the user to select an app from a specified team environment, | ||
| // returning the selected app. This app might require installation before use if `status == ShowAllApps`. | ||
| func TeamAppSelectPrompt(ctx context.Context, clients *shared.ClientFactory, env AppEnvironmentType, status AppInstallStatus) (SelectedApp, error) { |
Member
There was a problem hiding this comment.
praise: It's nice to be continually removing and consolidating code and functionality!
Base automatically changed from
zimeg-chore-remove-bolt-experiment-app-select
to
main
July 23, 2025 05:42
Member
Author
|
@mwbrooks Filtering apps for selection had so many steps before but I'm finding the "app with auth" value useful from this function too! Let's continue these improvement to code health and merge this PR. 🚢 💨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines the
AppSelectPromptandTeamAppSelectPromptinto theAppSelectPromptfollowing #158.Also included are improvements to the app selector mocks to expect a particular app environment and installation status 👾
No change to functionalities!
Requirements