CCIP - add ExtraDataCodecBundle protobuf and client/server support#1548
Merged
CCIP - add ExtraDataCodecBundle protobuf and client/server support#1548
Conversation
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
apidiff results - backwards-incompatible changes detected ❌Module:
|
| Element | Change |
|---|---|
./pkg/types/ccipocr3.ExtraDataCodec |
removed |
./pkg/types/ccipocr3.PriceReader.GetFeeQuoterTokenUpdates |
changed from func(context.Context, []UnknownEncodedAddress, ChainSelector) (map[UnknownEncodedAddress]TimestampedUnixBig, error) to func(context.Context, []UnknownAddress) (map[UnknownEncodedAddress]TimestampedUnixBig, error) |
(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/18044589751/#summary-51352120666)
ogtownsend
force-pushed
the
ogt/extra-data-codec-registry-interface-v3
branch
from
089e4b2 to
7e822af
Compare
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
force-pushed
the
ogt/extra-data-codec-registry-interface-v3
branch
from
7e822af to
d3306c1
Compare
ogtownsend
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
force-pushed
the
ogt/extra-data-codec-registry-interface-v3
branch
from
ebd888e to
4542724
Compare
ogtownsend
requested review from
0xAustinWang,
asoliman92,
chris-de-leon-cll,
makramkd,
matYang,
mateusz-sekara and
winder
ogtownsend
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
temporarily deployed
to
integration
GitHub Actions
Inactive
This was referenced Sep 19, 2025
ogtownsend
force-pushed
the
ogt/extra-data-codec-registry-interface-v3
branch
from
06d4446 to
661a3a9
Compare
ogtownsend
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
force-pushed
the
ogt/extra-data-codec-registry-interface-v3
branch
from
661a3a9 to
3d1af8f
Compare
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
temporarily deployed
to
integration
GitHub Actions
Inactive
amit-momin
approved these changes
Sep 26, 2025
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
commented
Sep 26, 2025
Comment on lines
+773
to
+798
| if extraDataCodecRes.Closer != nil { | ||
| extraDataCodecRes.Close() | ||
| } | ||
| return nil, err | ||
| } | ||
|
|
||
| // Sync persisted sync requests after provider has initted accessor | ||
| for contractName, addressBytes := range rargs.SyncedAddresses { | ||
| err = provider.ChainAccessor().Sync(ctx, contractName, addressBytes) | ||
| if err != nil { | ||
| if extraDataCodecRes.Closer != nil { | ||
| extraDataCodecRes.Close() | ||
| } | ||
| return nil, err | ||
| } | ||
| } | ||
|
|
||
| const name = "CCIPProvider" | ||
| resources := []net.Resource{{Closer: provider, Name: name}} | ||
| if extraDataCodecRes.Closer != nil { | ||
| resources = append(resources, extraDataCodecRes) | ||
| } | ||
|
|
||
| id, _, err := r.ServeNew(name, func(s *grpc.Server) { | ||
| ccipocr3.RegisterProviderServices(s, provider) | ||
| }, net.Resource{Closer: provider, Name: name}) | ||
| ccipocr3loop.RegisterProviderServices(s, provider) | ||
| }, resources...) |
Contributor
Author
There was a problem hiding this comment.
Hey @jmank88 does this closing logic seem correct to you?
jmank88
approved these changes
Sep 26, 2025
archseer
approved these changes
Sep 29, 2025
winder
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core ref: 6c66a0feb2886ad30d098654d527add7cf20068c
ExtraDataCodecBundleinterfaceRelated PRs: