[STALE] - CCIP - add ExtraDataCodecRegistry to sync SourceChainExtraDataCodecs across LOOPed relayers#19374
Closed
ogtownsend wants to merge 3 commits intodevelopfrom
Closed
Conversation
ogtownsend
commented
Sep 15, 2025
Comment on lines
+21
to
+24
| type ExtraDataCodecRegistry struct { | ||
| extraDataCodec cciptypes.ExtraDataCodecMap | ||
| mu sync.RWMutex | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Right now I don't have this implementing services.StateMachine to indicate when all codecs have been initialized, but I'd be open to the idea
ogtownsend
force-pushed
the
ogt/ccip-add-extradatacodec-registry-oracle-creator-v2
branch
2 times, most recently
from
1ecda28 to
8e6ee44
Compare
Contributor
|
I see you updated files related to
|
ogtownsend
force-pushed
the
ogt/ccip-add-extradatacodec-registry-oracle-creator-v2
branch
4 times, most recently
from
aa59466 to
726bada
Compare
ogtownsend
force-pushed
the
ogt/ccip-add-extradatacodec-registry-oracle-creator-v2
branch
6 times, most recently
from
50c6b4b to
d8a3881
Compare
ogtownsend
force-pushed
the
ogt/ccip-add-extradatacodec-registry-oracle-creator-v2
branch
from
d8a3881 to
c165c40
Compare
product-security-plaid-test
bot
requested review from
graham-chainlink,
jkongie and
securejavier
ogtownsend
requested review from
archseer,
huangzhen1997,
jadepark-dev and
jmank88
and removed request for
CL-Eric,
ChrisAmora,
DimitriosNaikopoulos,
DylanTinianov,
ajaskolski,
bytesizedroll,
giogam,
graham-chainlink,
jkongie and
securejavier
ogtownsend
force-pushed
the
ogt/ccip-add-extradatacodec-registry-oracle-creator-v2
branch
from
c165c40 to
2ab89e9
Compare
jmank88
approved these changes
Sep 19, 2025
|
|
|
||
| return codec.OracleIDAsAddressBytes(oracleID) | ||
| } | ||
| type AddressCodec = cciptypes.AddressCodecMap |
Contributor
There was a problem hiding this comment.
is there a reason that we keep this instead of just using common ccipocr3 ?
| // RegisterFamily registers a chain family with a no-op SourceChainExtraDataCodec if not already registered. | ||
| // This is used when we know which chain families we want to support but don't have a specific codec | ||
| // implementation initialized for it yet. This should only be called from core node, not over gRPC. | ||
| func (r *ExtraDataCodecRegistry) RegisterFamily(chainFamily string) { |
Contributor
There was a problem hiding this comment.
wonder if it would be more accurate to use RegisterNoop(), and call it when codec is missing from config
Collaborator
Author
There was a problem hiding this comment.
might do a combination of the two: RegisterFamilyNoop() 🤔
|
|
||
| // Add all families to the registries. If the codecs are provided by the config, set them here, otherwise | ||
| // ccipProvider will set them later in the oracle creator. | ||
| extraDataCodecRegistry.RegisterFamily(family) |
Contributor
There was a problem hiding this comment.
maybe we can call this when config.ExtraDataCodec is nil ?
Contributor
ogtownsend
changed the title
ogtownsend
deleted the
ogt/ccip-add-extradatacodec-registry-oracle-creator-v2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CCIP codec implementation faces a "chicken and egg" problem:
Codec()withinCCIPProviderrequires theextraDataCodec map (map[chainFamily]SourceChainExtraDataCodec).extraDataCodecmap requires the prior creation of all other codecs.ExtraDataCodecRegistrysingleton where chain families can be registered with no-opSourceChainExtraDataCodecimplementations until their actual source chain codecs are provided byCCIPProviderExtraDataCodecMapand can serve theExtraDataCodecBundleinterface over gRPCRelated PRs: