Bump cl-common import and update GetFeeQuoterTokenUpdates#190
Merged
ogtownsend merged 10 commits intomainfrom Sep 30, 2025
Merged
Bump cl-common import and update GetFeeQuoterTokenUpdates#190ogtownsend merged 10 commits intomainfrom
ogtownsend merged 10 commits intomainfrom
Conversation
ogtownsend
force-pushed
the
ogt/bump-cl-common-import
branch
from
ea1ff1c to
9c9b313
Compare
Collaborator
|
You probably need changes from the |
ogtownsend
force-pushed
the
ogt/bump-cl-common-import
branch
2 times, most recently
from
20276be to
0e80800
Compare
ogtownsend
commented
Sep 19, 2025
ogtownsend
force-pushed
the
ogt/bump-cl-common-import
branch
from
0e80800 to
85adeec
Compare
ogtownsend
changed the title
ogtownsend
force-pushed
the
ogt/bump-cl-common-import
branch
7 times, most recently
from
0338f58 to
145ae60
Compare
This was referenced Sep 19, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates chainlink-common import to a newer version and refactors CCIP code to use the updated API, particularly changing from ExtraDataCodec to ExtraDataCodecBundle and ExtraDataCodecMap. The changes also fix parameter types in the GetFeeQuoterTokenUpdates method.
- Updates chainlink-common and chainlink-ccip dependencies to newer versions
- Refactors ExtraDataCodec usage to new API types (ExtraDataCodecBundle/ExtraDataCodecMap)
- Updates GetFeeQuoterTokenUpdates parameter type from UnknownEncodedAddress to UnknownAddress
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/.core_version | Updates core version reference |
| pkg/ccip/ocr/contract_transmitter.go | Reorganizes import order for chainlink-common logger |
| pkg/ccip/codec/msghasher_test.go | Updates test code to use ExtraDataCodecMap instead of ExtraDataCodec |
| pkg/ccip/codec/msghasher.go | Changes type from ExtraDataCodec to ExtraDataCodecBundle |
| pkg/ccip/codec/executecodec_test.go | Updates test to use ExtraDataCodecMap |
| pkg/ccip/codec/executecodec.go | Changes type from ExtraDataCodec to ExtraDataCodecBundle |
| pkg/ccip/chainaccessor/ton_accessor.go | Updates GetFeeQuoterTokenUpdates method signature and implementation |
| integration-tests/go.mod | Updates dependency versions |
| go.mod | Updates dependency versions |
| deployment/go.mod | Updates dependency versions |
| cmd/chainlink-ton/lock.nix | Updates hash for chainlink-ton |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ogtownsend
force-pushed
the
ogt/bump-cl-common-import
branch
from
145ae60 to
a6632d6
Compare
ogtownsend
commented
Sep 19, 2025
| ctx context.Context, | ||
| tokens []ccipocr3.UnknownEncodedAddress, | ||
| chain ccipocr3.ChainSelector, | ||
| tokens []ccipocr3.UnknownAddress, |
Collaborator
Author
There was a problem hiding this comment.
cc @archseer and @huangzhen1997 for these changes
ogtownsend
force-pushed
the
ogt/bump-cl-common-import
branch
from
a6632d6 to
530abcf
Compare
archseer
reviewed
Sep 20, 2025
ogtownsend
force-pushed
the
ogt/bump-cl-common-import
branch
from
650f7a6 to
cc08e71
Compare
ogtownsend
force-pushed
the
ogt/bump-cl-common-import
branch
from
cc08e71 to
84eeaa0
Compare
ogtownsend
force-pushed
the
ogt/bump-cl-common-import
branch
2 times, most recently
from
be4ac81 to
b5cbcae
Compare
ogtownsend
force-pushed
the
ogt/bump-cl-common-import
branch
from
b5cbcae to
78c9ecd
Compare
archseer
reviewed
Sep 30, 2025
| var offRampAddrStr string | ||
| var err error | ||
|
|
||
| // NOTE: provider can still be initialized with an EVM offramp address, and AddressBytesToString will fail on addresses with len=20 |
Collaborator
There was a problem hiding this comment.
This is because of historical reasons, we instantiated CW for source chains so we'd be able to get fee estimations. I think we should change the logic and pass through an empty value here then avoid starting ContractTransmitter.
scripts/.core_version
Outdated
| @@ -1 +1 @@ | |||
| 77192d2721035b159f3cf46875445bf825971f73 | |||
| ogt/ccip-add-extradatacodec-registry-oracle-creator-v3 | |||
Collaborator
There was a problem hiding this comment.
Just leaving a note here so we don’t forget to update this to the fixed commit hash later.
ogtownsend
force-pushed
the
ogt/bump-cl-common-import
branch
from
0a06c95 to
0f21fca
Compare
huangzhen1997
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull in changes from cl-common PR and update
GetFeeQuoterTokenUpdates()signature and implRelated PRs: