boards: m5stack_cores3: enable 3-wire MIPI DBI panel #10
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| mipi_dbi { | ||
| compatible = "zephyr,mipi-dbi-spi"; | ||
| spi-dev = <&spi2>; | ||
| write-only; | ||
| status = "okay"; | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| ili9342c: ili9342c@0 { | ||
| compatible = "ilitek,ili9342c"; | ||
| reg = <0>; | ||
| status = "okay"; | ||
| mipi-max-frequency = <20000000>; | ||
| duplex = <SPI_HALF_DUPLEX>; | ||
| mipi-mode = "MIPI_DBI_MODE_SPI_3WIRE"; |
There was a problem hiding this comment.
[P1] Configure 3-wire DBI SPI to use 9-bit words
The new ili9342c panel is registered in three-wire MIPI DBI mode, but no SPI word-size change accompanies it. drivers/mipi_dbi/mipi_dbi_spi.c explicitly rejects 3‑wire transfers unless the SPI config uses 9-bit words (SPI_WORD_SET(9)), otherwise mipi_dbi_spi_write_helper_3wire() returns -ENOTSUP and the display never initializes. The ILI9xxx driver hard-codes SPI_WORD_SET(8) when building the configuration, so this DTS addition will always hit that failure path. The node needs to specify a 9-bit SPI operation (e.g., via a custom driver configuration or board override) before enabling 3-wire mode.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ce4f98bbc083229f56753a621368ac