Skip to content

boards: m5stack_cores3: enable 3-wire MIPI DBI panel #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

boards: m5stack_cores3: enable 3-wire MIPI DBI panel #10

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ae4e7e
boards: m5stack_cores3: enable 3-wire MIPI DBI panel
soburi Sep 20, 2025
2693611
boards: m5stack_cores3: gate lcd pins behind pinctrl states
soburi Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions boards/m5stack/m5stack_cores3/Kconfig.defconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,7 @@ if BOARD_M5STACK_CORES3_ESP32S3_PROCPU || BOARD_M5STACK_CORES3_ESP32S3_PROCPU_SE
config INPUT
default y

config MIPI_DBI_SPI_3WIRE
default y

endif # BOARD_M5STACK_CORES3_ESP32S3_PROCPU || BOARD_M5STACK_CORES3_ESP32S3_PROCPU_SE
56 changes: 42 additions & 14 deletions boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,22 @@
#include "m5stack_cores3-pinctrl.dtsi"
#include "m5stack_mbus_connectors.dtsi"
#include "grove_connectors.dtsi"
#include <zephyr/dt-bindings/display/ili9xxx.h>
#include <zephyr/dt-bindings/mipi_dbi/mipi_dbi.h>
#include <zephyr/dt-bindings/spi/spi.h>

/ {
chosen {
zephyr,sram = &sram1;
zephyr,console = &usb_serial;
zephyr,shell-uart = &usb_serial;
zephyr,flash = &flash0;
zephyr,code-partition = &slot0_partition;
zephyr,rtc = &bm8563_rtc;
zephyr,bt-hci = &esp32_bt_hci;
zephyr,touch = &ft6336_touch;
};
chosen {

Check warning on line 17 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:17  please, no spaces at the start of a line

Check failure on line 17 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:17  code indent should use tabs where possible
zephyr,sram = &sram1;

Check warning on line 18 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:18  please, no spaces at the start of a line

Check failure on line 18 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:18  code indent should use tabs where possible
zephyr,console = &usb_serial;

Check warning on line 19 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:19  please, no spaces at the start of a line

Check failure on line 19 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:19  code indent should use tabs where possible
zephyr,shell-uart = &usb_serial;

Check warning on line 20 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:20  please, no spaces at the start of a line

Check failure on line 20 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:20  code indent should use tabs where possible
zephyr,flash = &flash0;

Check warning on line 21 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:21  please, no spaces at the start of a line

Check failure on line 21 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:21  code indent should use tabs where possible
zephyr,code-partition = &slot0_partition;

Check warning on line 22 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:22  please, no spaces at the start of a line

Check failure on line 22 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:22  code indent should use tabs where possible
zephyr,rtc = &bm8563_rtc;

Check warning on line 23 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:23  please, no spaces at the start of a line

Check failure on line 23 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:23  code indent should use tabs where possible
zephyr,bt-hci = &esp32_bt_hci;

Check warning on line 24 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:24  please, no spaces at the start of a line

Check failure on line 24 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:24  code indent should use tabs where possible
zephyr,touch = &ft6336_touch;

Check warning on line 25 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:25  please, no spaces at the start of a line

Check failure on line 25 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:25  code indent should use tabs where possible
zephyr,display = &ili9342c;

Check warning on line 26 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:26  please, no spaces at the start of a line

Check failure on line 26 in boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

CODE_INDENT 

boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi:26  code indent should use tabs where possible
};

aliases {
uart-0 = &uart0;
Expand All @@ -35,10 +39,34 @@
fuel-gauge0 = &fuel_gauge;
};

lvgl_pointer {
compatible = "zephyr,lvgl-pointer-input";
input = <&ft6336_touch>;
};
lvgl_pointer {
compatible = "zephyr,lvgl-pointer-input";
input = <&ft6336_touch>;
};

mipi_dbi {
compatible = "zephyr,mipi-dbi-spi";
spi-dev = <&spi2>;
write-only;
status = "okay";
#address-cells = <1>;
#size-cells = <0>;

ili9342c: ili9342c@0 {
compatible = "ilitek,ili9342c";
reg = <0>;
status = "okay";
mipi-max-frequency = <20000000>;
duplex = <SPI_HALF_DUPLEX>;
mipi-mode = "MIPI_DBI_MODE_SPI_3WIRE";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Configure 3-wire DBI SPI to use 9-bit words

The new ili9342c panel is registered in three-wire MIPI DBI mode, but no SPI word-size change accompanies it. drivers/mipi_dbi/mipi_dbi_spi.c explicitly rejects 3‑wire transfers unless the SPI config uses 9-bit words (SPI_WORD_SET(9)), otherwise mipi_dbi_spi_write_helper_3wire() returns -ENOTSUP and the display never initializes. The ILI9xxx driver hard-codes SPI_WORD_SET(8) when building the configuration, so this DTS addition will always hit that failure path. The node needs to specify a 9-bit SPI operation (e.g., via a custom driver configuration or board override) before enabling 3-wire mode.

Useful? React with 👍 / 👎.

vin-supply = <&vcc_bl>;
pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
display-inversion;
width = <320>;
height = <240>;
rotation = <0>;
};
};
};

&usb_serial {
Expand Down
Loading