forked from NREL/GEOPHIRES-X
-
Notifications
You must be signed in to change notification settings - Fork 1
Add 'Discount Initial Year Cashflow' parameter for Excel-style NPV calculation [v3.8.4] #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
… Initial Year Cashflow' to match Excel's (simpler) convention, which does not treat cash outlays spread over multiple initial years differently.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change enables GEOPHIRES to use Excel-style NPV calculation per user feature request as discussed in NREL#344. This is achieved through the addition of a boolean input parameter
Discount Initial Year Cashflow
(final name/documentation open to discussion/suggestion) with default value =False
(existing NPV calculation behavior) and the option to provide value =True
to use Excel-style NPV calculation.The change also includes testing to establish/confirm parity between GEOPHIRES NPV calculation and the NREL manual's NPV calculation convention per NREL#344 (comment): https://github.com/softwareengineerprogrammer/GEOPHIRES/pull/55/files#diff-780d3d576fea7650243d4fdf0272c5ca5ed2d3751cd09fe0cca69fc1a59b21c8R61-R68
Discount Initial Year Cashflow
in web interface parameter browser:Testing & Verification
Discount Initial Year Cashflow
=True
)*: confirmed that the GEOPHIRES result NPV value of $4280.71M matches the value when calculated using a spreadsheet software NPV function from the result's revenue profile:TODO:
false
/False
e.g.abc
is treated as true, should validate that provided values are boolean-y: created tracking issue Arbitrary strings treated as True for boolean parameters NREL/GEOPHIRES-X#362*Input: