Push moveit2 and nav2 images to Docker Hub (issue #254)

[mkhansenbot]

Pushes the moveit2 and nav2 images to Docker Hub with tags, the same way that the space-ros image is pushed. It also pushes to GHCR for use in CI, in the same way as the base space-ros container(s).

Edit: These are the Docker Hub repos it pushes to.
https://hub.docker.com/r/osrf/space-ros-moveit2
https://hub.docker.com/r/osrf/space-ros-nav2

[mkhansenbot]

This is now ready for review

[mkhansenbot]

Ignore the fact that it says the space_nav2 and space_robots builds haven't completed. This PR replaces those with the space-ros-nav2 and space-ros-moveit2 builds.

[mkhansenbot]

Made one minor change to the Moveit2 Docker build name to make it more clear

[eholum]

Hooray! This will be so great. Sorry for the delay in getting to testing this. I pulled both the moveit2 and nav2 images and just sanity checked them and they seem good!

Had a few minor, minor comments. And can you also update the moveit2 README to have the new image names? There are some leftovers, for instance in moveit:

https://github.com/space-ros/docker/tree/push_images/moveit2#running-the-moveit2-docker-image-in-a-container

[mkhansenbot]

Updated per your review comments @eholum, please review the updates.

[eholum]

Looks good @mkhansenbot! The one last thing I would request is just to squash the PR comment comments into their respective commits. Sorry for the trouble, that's what the last bullet point in https://github.com/space-ros/.github/blob/master/CONTRIBUTING.md#pull-requests references - just keeping the commit message history clean.

And then I think we need to change the repo requirements to remove the old CI checks. I don't have permission, can you see those options? https://github.com/space-ros/docker/settings

[mkhansenbot]

Thanks Erik, I'll clean up the history a little bit this weekend. As for removing the old CI checks, I think those will be removed by this PR. If not, I think we can merge this and then if they're still hanging around as ghosts, we can address that separately.

[EzraBrooks]

Ping me once you've cleaned up the history and I'll make the repo settings change to require the new jobs and not require the old jobs.

[mkhansenbot]

@eholum - I squashed this down to 2 commits, but listed the main changes under the primary commit, so it's clear what this does. Let me know if this is good. I'd like to get it merged for this release

Re-requesting approval after addressing the review comment

[eholum]

Woohoo!

@EzraBrooks I think we'll need those CI required checks settings adjusted if you're able to do that?