fix: resolve pre-existing CI failures (clippy, fmt, test)#174
Merged
jamiepine merged 1 commit intospacedriveapp:mainfrom Feb 23, 2026
Merged
fix: resolve pre-existing CI failures (clippy, fmt, test)#174jamiepine merged 1 commit intospacedriveapp:mainfrom
jamiepine merged 1 commit intospacedriveapp:mainfrom
Conversation
This was referenced Feb 23, 2026
Collaborator
Author
|
@jamiepine I would suggest we enable the "must pass CI for merging PR" setting to avoid having to fix this over and over :) |
This was referenced Feb 23, 2026
Fix 17 clippy errors that were failing CI on main: - Collapse nested if blocks using let-chains (stable since Rust 1.88) - Use ? operator instead of let-else returning None (config.rs) - Suppress too_many_arguments on TwitchAdapter::new - Move mod tests to end of cron/scheduler.rs (items_after_test_module) Fix bold_and_italic_nested test: add BOLD_ITALIC_PATTERN for ***text*** processed before bold/italic, producing correct <b><i>text</i></b> nesting. Fix tests/context_dump.rs: render_channel_prompt returns Result, add .unwrap_or_default() to match current return type.
931105c to
934be05
Compare
Member
|
Great idea, will enable that now! I also invited you as a collaborator to the repo, your contributions have been awesome, you're the top contributor. Would also be great to have a line of communication without outside of GitHub, so if you want please email jamie@spacedrive.com |
jamiepine
approved these changes
Feb 23, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 17 pre-existing clippy errors, a failing test, and a broken integration test that were blocking CI on
mainand on any PR branching from it.Clippy (collapsible-if, question-mark, too-many-arguments, items-after-test-module):
ifblocks using let-chains (stable since Rust 1.88 / edition 2024)?instead oflet Some(x) = y else { return None }inconfig.rs#[allow(clippy::too_many_arguments)]onTwitchAdapter::newmod teststo end ofcron/scheduler.rsto fixitems_after_test_moduleTest fix (
messaging::telegram::tests::bold_and_italic_nested):Add a
BOLD_ITALIC_PATTERNfor***text***processed before the bold/italic patterns, so triple-star produces correct<b><i>text</i></b>nesting instead of<b><i>text</b></i>.Integration test fix (
tests/context_dump.rs):SkillSet::render_channel_promptreturnsResult<String>but the test was using it asString. Add.unwrap_or_default().