Skip to content

fix: resolve pre-existing CI failures (clippy, fmt, test)#174

Merged
jamiepine merged 1 commit intospacedriveapp:mainfrom
Marenz:fix/ci-preexisting-failures
Feb 23, 2026
Merged

fix: resolve pre-existing CI failures (clippy, fmt, test)#174
jamiepine merged 1 commit intospacedriveapp:mainfrom
Marenz:fix/ci-preexisting-failures

Conversation

@Marenz
Copy link
Collaborator

@Marenz Marenz commented Feb 23, 2026

Fixes 17 pre-existing clippy errors, a failing test, and a broken integration test that were blocking CI on main and on any PR branching from it.

Clippy (collapsible-if, question-mark, too-many-arguments, items-after-test-module):

  • Collapse nested if blocks using let-chains (stable since Rust 1.88 / edition 2024)
  • Use ? instead of let Some(x) = y else { return None } in config.rs
  • Add #[allow(clippy::too_many_arguments)] on TwitchAdapter::new
  • Move mod tests to end of cron/scheduler.rs to fix items_after_test_module

Test fix (messaging::telegram::tests::bold_and_italic_nested):
Add a BOLD_ITALIC_PATTERN for ***text*** processed before the bold/italic patterns, so triple-star produces correct <b><i>text</i></b> nesting instead of <b><i>text</b></i>.

Integration test fix (tests/context_dump.rs):
SkillSet::render_channel_prompt returns Result<String> but the test was using it as String. Add .unwrap_or_default().

@Marenz
Copy link
Collaborator Author

Marenz commented Feb 23, 2026

@jamiepine I would suggest we enable the "must pass CI for merging PR" setting to avoid having to fix this over and over :)

Fix 17 clippy errors that were failing CI on main:
- Collapse nested if blocks using let-chains (stable since Rust 1.88)
- Use ? operator instead of let-else returning None (config.rs)
- Suppress too_many_arguments on TwitchAdapter::new
- Move mod tests to end of cron/scheduler.rs (items_after_test_module)

Fix bold_and_italic_nested test: add BOLD_ITALIC_PATTERN for ***text***
processed before bold/italic, producing correct <b><i>text</i></b> nesting.

Fix tests/context_dump.rs: render_channel_prompt returns Result, add
.unwrap_or_default() to match current return type.
@jamiepine
Copy link
Member

Great idea, will enable that now! I also invited you as a collaborator to the repo, your contributions have been awesome, you're the top contributor.

Would also be great to have a line of communication without outside of GitHub, so if you want please email jamie@spacedrive.com

@jamiepine jamiepine merged commit 82e6678 into spacedriveapp:main Feb 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants