Change @Bean method signature to return RsaKeyConversionServicePostProcessor instead of BeanFactoryPostProcessor #17672
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
…ocessor instead of BeanFactoryPostProcessor It's friendly for Spring Boot's `@ConditionalOnMissingBean`, and: >> When defining a Spring `@Bean` method, it is generally recommended to declare the most specific type possible as the method's return type. This means returning the concrete class of the bean, or the most specific interface that the bean implements and through which it will be referenced in the application. Signed-off-by: Yanming Zhou <[email protected]>
jzheaux
reviewed
Aug 13, 2025
| * @since 5.0 | ||
| */ | ||
| @Configuration(proxyBeanMethods = false) | ||
| class WebFluxSecurityConfiguration { | ||
|
|
||
| public static final int WEB_FILTER_CHAIN_FILTER_ORDER = 0 - 100; | ||
| public static final int WEB_FILTER_CHAIN_FILTER_ORDER = -100; |
There was a problem hiding this comment.
Thanks for this polish, @quaff. Will you do me the favor of placing it in a separate commit since it is unrelated to updating the return type of the post processor?
jzheaux
added
in: config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's friendly for Spring Boot's
@ConditionalOnMissingBean, and: