feat: Add boil tool #1224
feat: Add boil tool #1224
Conversation
Only send out notifications if the build failed, a build is re-run and wasn't cancelled.
|
Worth pointing out that when this merges, bake will no longer work. |
Oh yeah, good point. I will add it to the description. |
There was a problem hiding this comment.
Tried running cargo boil build airflow. Got this as a result:
WARNING: No output specified for entry--airflow-2_10_4, entry--airflow-2_10_5, entry--airflow-2_9_3, entry--airflow-3_0_1 target(s) with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
Successfully built 4 images:
oci.stackable.tech/sdp/airflow:2.10.4-stackable0.0.0-dev-amd64
oci.stackable.tech/sdp/airflow:2.10.5-stackable0.0.0-dev-amd64
oci.stackable.tech/sdp/airflow:2.9.3-stackable0.0.0-dev-amd64
oci.stackable.tech/sdp/airflow:3.0.1-stackable0.0.0-dev-amd64
Images weren't there and running cargo boil build airflow --load or cargo boil build airflow -- --load didn't work.
| # Reassign the arg to `HADOOP_VERSION` for better readability. | ||
| ENV HADOOP_VERSION=${HADOOP_HADOOP} | ||
| ENV HADOOP_VERSION=${HADOOP_HADOOP_VERSION} |
There was a problem hiding this comment.
Is the reassignment still necessary if the ARG got renamed for better readability? Unless something else than specifying it's a version was meant
There was a problem hiding this comment.
ENVs persist in the built image, while ARGs are only for build time. So this allows us to convert an ARG (fleeting) into an ENV (permanent).
| ARG HBASE_HBASE_OPERATOR_TOOLS | ||
| ARG HBASE_HBASE_OPA_AUTHORIZER | ||
| ARG HBASE_PHOENIX | ||
| ENV HBASE_VERSION=${HBASE_HBASE_VERSION} |
There was a problem hiding this comment.
Same as above, there seems to be some additional occurrences of that
| java-base = "21" | ||
| java-devel = "21" |
There was a problem hiding this comment.
| java-base = "21" | |
| java-devel = "21" | |
| java-base = "23" | |
| java-devel = "23" |
According to deleted versions file
| [versions."3.3.6".build-arguments] | ||
| async-profiler-version = "2.9" | ||
| jmx-exporter-version = "1.3.0" | ||
| protobuf-version = "3.7.1" |
There was a problem hiding this comment.
| protobuf-version = "3.7.1" |
This wasn't part of the previous version file and is not used in the Dockerfile as far as I can see (also an occurence in the version below)
| cyclonedx-bom-version = "6.0.0" | ||
| tini-version = "0.19.0" | ||
| uv-version = "0.7.8" | ||
| airflow-extras = "async,amazon,celery,cncf.kubernetes,docker,dask,elasticsearch,ftp,grpc,hashicorp,http,ldap,google,google_auth,microsoft.azure,odbc,pandas,postgres,redis,sendgrid,sftp,slack,ssh,statsd,virtualenv,trino" |
There was a problem hiding this comment.
| airflow-extras = "async,amazon,celery,cncf.kubernetes,docker,dask,elasticsearch,ftp,grpc,hashicorp,http,ldap,google,google_auth,microsoft.azure,odbc,pandas,postgres,redis,sendgrid,sftp,slack,ssh,statsd,virtualenv,trino" | |
| airflow-extras = "async,amazon,celery,cncf-kubernetes,docker,elasticsearch,fab,ftp,grpc,hashicorp,http,ldap,google,microsoft-azure,odbc,pandas,postgres,redis,sendgrid,sftp,slack,ssh,statsd,trino" |
Taken from previous version file
Caution
Once this merges,
bakewill no longer be compatible with this repository. As such, the GHA workflow needs to be adjusted to work withboil.Note
This was ✨ magically ✨ developed in my spare time and I'm happy to fully hand over this code to Stackable.
This PR adds
boil, a replacement forbakewritten in Rust.bake --preflightcommand is for example currently broken on main (even if unused)._VERSIONto local image versions ARGsdocker)I additionally have some cool ideas (dealing with supported product versions for example), but I don't wanna spoil them just yet.