starknet_committer: add index layout nodes #10682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2025
|
This change is |
This was referenced Dec 10, 2025
Contributor
Author
This was referenced Dec 10, 2025
ArielElp
force-pushed
the
ariel/add_index_layout_leaves
branch
from
01c2851 to
ba78a66
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
4402c0e to
5a62fc2
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_leaves
branch
from
ba78a66 to
7578dc0
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
2 times, most recently
from
b3f70f7 to
70f1731
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_leaves
branch
2 times, most recently
from
59b51ce to
f733314
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
70f1731 to
6c50273
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_leaves
branch
from
f733314 to
8ff59c0
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
6c50273 to
9f1b96e
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_leaves
branch
from
8ff59c0 to
ac40644
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
9f1b96e to
c3c62a4
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_leaves
branch
from
ac40644 to
e30a635
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
c3c62a4 to
e664009
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_leaves
branch
from
e30a635 to
f25ec01
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
e664009 to
909fb4e
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_leaves
branch
from
f25ec01 to
aad75aa
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
909fb4e to
2c4bcff
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
2 times, most recently
from
1c1145c to
14fb5d0
Compare
ArielElp
commented
Dec 25, 2025
Contributor
Author
ArielElp
left a comment
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 2 comments.
Reviewable status: 4 of 7 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware).
crates/starknet_committer/src/db/index_db/serde_tests.rs line 64 at r12 (raw file):
Previously, dorimedini-starkware wrote…
ok now I notice these functions have no arguments:
please convert them to statics with LazyLock (see example in the first one).
this is useful so we don't compute the same hashes multiple times (there will be more tests in the future, I guess).another approach would be to create 3 utility functions that get nice "regular numbers" as input and output these complex objects, to reduce boilerplate (this is what we did in the starknet_patricia crate tests)
Done (moved the three objects whose construction involves hashing under LazyLock)
crates/starknet_committer/src/db/index_db/serde_tests.rs line 155 at r12 (raw file):
Previously, dorimedini-starkware wrote…
what is this dark magic
Just U256 from two u128 (wrong shift direction on high 128 bits... fixed)
I realized U256 has shift so just doing the right thing now
ArielElp
force-pushed
the
ariel/index_layout_subtree
branch
from
f0ae1a9 to
c0a23c6
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
14fb5d0 to
0070c94
Compare
dorimedini-starkware
approved these changes
Dec 25, 2025
Collaborator
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 3 files and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArielElp).
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
0070c94 to
e6d71c6
Compare
ArielElp
force-pushed
the
ariel/index_layout_subtree
branch
from
c0a23c6 to
08c16bf
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
e6d71c6 to
da5f5c2
Compare
ArielElp
force-pushed
the
ariel/index_layout_subtree
branch
2 times, most recently
from
ad3c4db to
ff8df93
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
da5f5c2 to
d8d9f88
Compare
ArielElp
changed the base branch from
ariel/index_layout_subtree
to
graphite-base/10682
ArielElp
force-pushed
the
graphite-base/10682
branch
from
ff8df93 to
d0c0f43
Compare
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
d8d9f88 to
ca195e9
Compare
ArielElp
changed the base branch from
graphite-base/10682
to
main-v0.14.1-committer
ArielElp
requested review from
dorimedini-starkware,
nimrod-starkware and
yoavGrs
ArielElp
force-pushed
the
ariel/add_index_layout_node_and_subtree
branch
from
ca195e9 to
dfaaf90
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.