starknet_committer,starknet_patricia: add deserialization context

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• starknet_committer: add commit e2e tests #11331
• index layout forest creation tests #11286
• starknet_committer,starknet_patricia: layout-based original tree creation tests #11236
• starknet_committer,starknet_patricia: layout-dependent FilledTree serialization #10988
• starknet_committer,starknet_patricia: add layout for base trait #11566
• starknet_committer,starknet_patricia: add serialization utilities to node layout #10987
• starknet_committer,starknet_patricia: move db_layout #10986
• starknet_committer: add index db #10685
• starknet_committer: abstract original tree creation #10684
• starknet_committer: enrich layout trait to abstract skeleton creation #11182
• starknet_committer: move trie creation logic to trie_traversal #11180
• starknet_committer: group generic layout logic #10852
• starknet_committer,starknet_patricia: remove generic config #10683
• starknet_committer: add index layout nodes #10682
• starknet_committer: add index layout subtree #10919
• starknet_committer: hash leaves of both layouts #10918
• starknet_committer: add index layout leaves #10681
• starknet_committer,starknet_patricia,starknet_patricia_storage: support contract address prefix #10858
• starknet_committer,starknet_patricia: add serde errors #10810
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: layout dependent fetch_nodes #10680
• starknet_committer,starknet_patricia: enrich subtree trait to support fetch nodes #10751
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: make FilledNode generic #10750
• starknet_committer,starknet_os,starknet_patricia: make node data generic #10679
• starknet_committer,starknet_patricia: add deserialization context #10704 👈 (View in Graphite)
• starknet_committer,starknet_patricia,starknet_patricia_storage: add context to prefix and serde #10678
• starknet_committer,starknet_patricia: add subtree trait #10694
• starknet_committer: reorganize facts db files #10677
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[nimrod-starkware]

@nimrod-starkware reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ArielElp)

---

crates/starknet_patricia/src/patricia_merkle_tree/filled_tree/node_serde.rs line 66 at r1 (raw file):

    pub is_leaf: bool,
    pub node_hash: HashOutput,
}

Name is too general IMO + doc

Suggestion:

/// Extra context required to deserialize [FilledNode].
/// See [DBObject::DeserializeContext] for more information.
pub struct FilledNodeDeserializeContext {
    pub is_leaf: bool,
    pub node_hash: HashOutput,
}

---

crates/starknet_patricia/src/patricia_merkle_tree/filled_tree/node_serde.rs line 68 at r1 (raw file):

}

impl<L: Leaf> DBObject for FilledNode<L> {

Do you plan to have a different type of FilledNode for the index layout?

Code quote:

impl<L: Leaf> DBObject for FilledNode<L> {

---

crates/starknet_patricia/src/patricia_merkle_tree/node_data/leaf.rs line 14 at r1 (raw file):

pub trait Leaf:
    Clone + Sync + Send + HasStaticPrefix + DBObject<DeserializeContext = ()> + Default + Debug + Eq

Can you give an alias for this and use it here (and possibly other places)?
Does this work?
pub trait ContextLessDBObejct: DBObject<DeserializeContext = ()> {}

Code quote:

DBObject<DeserializeContext = ()>

[ArielElp]

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @yoavGrs)

---

crates/starknet_patricia/src/patricia_merkle_tree/filled_tree/node_serde.rs line 55 at r5 (raw file):

Previously, yoavGrs wrote…

Restore the empty line, please

Done.

---

crates/starknet_patricia_storage/src/db_object.rs line 46 at r4 (raw file):

Previously, yoavGrs wrote…

It would be done in 2 PRs, but NVM now

Ack

[yoavGrs]

@yoavGrs reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp)

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 of 6 files at r2, 2 of 4 files at r4, 1 of 1 files at r5, 1 of 2 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp)

---

crates/starknet_patricia/src/patricia_merkle_tree/node_data/leaf.rs line 22 at r7 (raw file):

    + Send
    + HasStaticPrefix
    + DBObject<DeserializeContext = EmptyDeserializationContext>

why are leaves always with empty deserialization context? never required?

Code quote:

DBObject<DeserializeContext = EmptyDeserializationContext>

---

crates/starknet_patricia/src/patricia_merkle_tree/filled_tree/node_serde.rs line 118 at r7 (raw file):

            return Ok(Self {
                hash: deserialize_context.node_hash,
                data: NodeData::Leaf(L::deserialize(value, &EmptyDeserializationContext)?),

isn't this what you want...?

Suggestion:

NodeData::Leaf(L::deserialize(value, &L::DeserializeContext)?)

[ArielElp]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/starknet_patricia/src/patricia_merkle_tree/filled_tree/node_serde.rs line 118 at r7 (raw file):

Previously, dorimedini-starkware wrote…

isn't this what you want...?

I need an instantiation, L::DeserializeContext is the type

---

crates/starknet_patricia/src/patricia_merkle_tree/node_data/leaf.rs line 22 at r7 (raw file):

Previously, dorimedini-starkware wrote…

why are leaves always with empty deserialization context? never required?

I never use it for leaves. Facts context is is_leaf+hash, index context is is_leaf, for leaves there's no ambiguity on db reads that I need to solve externally.

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp)