Skip to content

starknet_committer,starknet_patricia,starknet_patricia_storage: support contract address prefix #10858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ArielElp merged 1 commit into from
Dec 24, 2025
Merged

starknet_committer,starknet_patricia,starknet_patricia_storage: support contract address prefix #10858

ArielElp merged 1 commit into from
Dec 24, 2025

Conversation

@ArielElp
Copy link
Contributor

@ArielElp ArielElp commented Dec 17, 2025

No description provided.

This was referenced Dec 17, 2025
Merged
Open
Merged
Merged
Open
Merged
@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Dec 17, 2025

This change is Reviewable

This was referenced Dec 17, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ArielElp Graphite App
Copy link
Contributor Author

ArielElp commented Dec 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArielElp ArielElp mentioned this pull request Dec 17, 2025
Merged
@ArielElp ArielElp marked this pull request as ready for review December 17, 2025 08:47
nimrod-starkware
nimrod-starkware approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@ArielElp ArielElp force-pushed the ariel/add_serde_errors branch from 4b39ed1 to 4b32085 Compare December 17, 2025 14:34
@ArielElp ArielElp force-pushed the ariel/support_owned_db_prefixes branch from 125914b to 0371ece Compare December 17, 2025 14:34
yoavGrs
yoavGrs approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@yoavGrs reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).

@ArielElp ArielElp force-pushed the ariel/add_serde_errors branch from 4b32085 to dd10700 Compare December 21, 2025 06:28
@ArielElp ArielElp force-pushed the ariel/support_owned_db_prefixes branch from 0371ece to 933c3f3 Compare December 21, 2025 06:28
This was referenced Dec 21, 2025
Merged
Merged
dorimedini-starkware
dorimedini-starkware requested changes Dec 22, 2025
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp).

a discussion (no related file):

  1. why do you need Cow?
  2. why is the PR title "support contract address prefix"?

@ArielElp ArielElp force-pushed the ariel/support_owned_db_prefixes branch from f791251 to eb93872 Compare December 23, 2025 13:00
@ArielElp ArielElp force-pushed the ariel/add_serde_errors branch from f51d69b to 384f2ca Compare December 23, 2025 13:00
ArielElp
ArielElp commented Dec 23, 2025
View reviewed changes
Copy link
Contributor Author

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielElp made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @yoavGrs).

a discussion (no related file):

Previously, dorimedini-starkware wrote…
  1. why do you need Cow?
  2. why is the PR title "support contract address prefix"?

Previously there was only constants prefixes (inner nde --> "inner node" or some constant per leaf type for leaf).

With index layouts, I have prefixes which are either constants (the static lifetime borrowed variant of Cow), or, for the storage trie, prefixes that depend on a dynmaically constructed ContractAddress (the owned variant).

dorimedini-starkware
dorimedini-starkware approved these changes Dec 23, 2025
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).

@ArielElp ArielElp force-pushed the ariel/support_owned_db_prefixes branch from eb93872 to 9baa41f Compare December 23, 2025 15:36
@ArielElp ArielElp force-pushed the ariel/add_serde_errors branch from 384f2ca to 40351f5 Compare December 23, 2025 15:37
@ArielElp ArielElp changed the base branch from ariel/add_serde_errors to graphite-base/10858 December 23, 2025 15:42
@ArielElp ArielElp force-pushed the ariel/support_owned_db_prefixes branch from 9baa41f to 8ae5406 Compare December 23, 2025 15:46
@ArielElp ArielElp force-pushed the graphite-base/10858 branch from 40351f5 to 3bd24d9 Compare December 23, 2025 15:46
@ArielElp ArielElp changed the base branch from graphite-base/10858 to ariel/add_serde_errors December 23, 2025 15:46
@ArielElp ArielElp force-pushed the ariel/add_serde_errors branch from 3bd24d9 to b4c834d Compare December 24, 2025 08:50
@ArielElp ArielElp force-pushed the ariel/support_owned_db_prefixes branch from 8ae5406 to 7ac0b04 Compare December 24, 2025 08:50
dorimedini-starkware
dorimedini-starkware approved these changes Dec 24, 2025
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).

@ArielElp ArielElp force-pushed the ariel/support_owned_db_prefixes branch from 7ac0b04 to d2591b8 Compare December 24, 2025 11:38
@ArielElp ArielElp force-pushed the ariel/add_serde_errors branch from b4c834d to 9a59bb0 Compare December 24, 2025 11:38
@ArielElp ArielElp force-pushed the ariel/support_owned_db_prefixes branch from d2591b8 to dae7822 Compare December 24, 2025 11:41
@ArielElp ArielElp force-pushed the ariel/add_serde_errors branch from 9a59bb0 to c17c0aa Compare December 24, 2025 11:41
@ArielElp ArielElp force-pushed the ariel/support_owned_db_prefixes branch from dae7822 to c9d93da Compare December 24, 2025 11:59
@ArielElp ArielElp force-pushed the ariel/add_serde_errors branch from c17c0aa to 20db9ea Compare December 24, 2025 11:59
@ArielElp ArielElp force-pushed the ariel/support_owned_db_prefixes branch from c9d93da to e57563d Compare December 24, 2025 12:59
dorimedini-starkware
dorimedini-starkware approved these changes Dec 24, 2025
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).

@ArielElp ArielElp changed the base branch from ariel/add_serde_errors to main-v0.14.1-committer December 24, 2025 13:22
@ArielElp ArielElp force-pushed the ariel/support_owned_db_prefixes branch from e57563d to 1c97905 Compare December 24, 2025 13:33
@ArielElp ArielElp added this pull request to the merge queue Dec 24, 2025
Merged via the queue into main-v0.14.1-committer with commit 7319de2 Dec 24, 2025
18 checks passed
This was referenced Dec 25, 2025
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

@yoavGrs yoavGrs yoavGrs approved these changes

@nimrod-starkware nimrod-starkware nimrod-starkware approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ArielElp @reviewable-StarkWare @dorimedini-starkware @yoavGrs @nimrod-starkware