starknet_committer: add commit e2e tests

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• starknet_committer,starknet_patricia: move node_serde to facts db #11644
• starknet_committer: reorganize db modules #11640
• starknet_committer: add commit e2e tests #11331 👈 (View in Graphite)
• starknet_committer: index layout forest creation tests #11286
• starknet_committer: mock tree hash function #12224
• starknet_committer: generic hash in index layout #12223
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[nimrod-starkware]

@nimrod-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ArielElp).

---

crates/starknet_committer/src/db/facts_db/types.rs line 71 at r1 (raw file):

        })
    }
}

should do the same thing :)

Suggestion:

#[derive(Clone, Debug, Default, PartialEq)]
pub struct FactsDbInitialRead(pub StateRoots);

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware).

---

crates/starknet_committer/src/db/facts_db/types.rs line 71 at r1 (raw file):

Previously, nimrod-starkware wrote…

should do the same thing :)

Done.

[nimrod-starkware]

@nimrod-starkware reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 3 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ArielElp).

---

crates/starknet_committer/src/db/facts_db/types.rs line 62 at r3 (raw file):

/// Used for reading the roots in facts layout case.
#[derive(Clone, Debug, Default, PartialEq)]
pub struct FactsDbInitialRead(pub StateRoots);

non-blocking, because StateRoots does have a natural default; however, still consider this, if it's dangerous to accidentally use a default value in production

Suggestion:

#[cfg_attr(any(test, feature = "testing"), derive(Default))]
#[derive(Clone, Debug, PartialEq)]
pub struct FactsDbInitialRead(pub StateRoots);

---

crates/starknet_committer/src/block_committer/commit_test.rs line 60 at r3 (raw file):

#[rstest]
#[case([get_first_state_diff(), get_second_state_diff()], EXPECTED_ROOTS_SIMPLE_CASE)]
#[case(get_random_state_diffs(), EXPECTED_ROOTS_RANDOM_CASE)]

works, but seems odd; I would consider using expect! to generate the expected roots given the "random" state diffs.
if index layout and facts layout diverge, you will still fail at least one of the tests.
non-blocking

Code quote:

#[case(get_random_state_diffs(), EXPECTED_ROOTS_RANDOM_CASE)]

---

crates/starknet_committer/src/block_committer/commit_test.rs line 101 at r3 (raw file):

    expected_roots: StateRoots,
) {
    let [first_state_diff, second_state_diff] = state_diffs;

non-blocking

Suggestion:

    [first_state_diff, second_state_diff]: [StateDiff; 2],
    expected_roots: StateRoots,
) {
    

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ArielElp).

[ArielElp]

@ArielElp made 1 comment and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware).

---

crates/starknet_committer/src/block_committer/commit_test.rs line 60 at r3 (raw file):

Previously, dorimedini-starkware wrote…

works, but seems odd; I would consider using expect! to generate the expected roots given the "random" state diffs.
if index layout and facts layout diverge, you will still fail at least one of the tests.
non-blocking

AFAIU it would require a different assertion line in each layout test, and DB layouts shouldn't affect the resulting roots, this would be a protocol change (OS changes + nodes changes etc.)

[ArielElp]

@ArielElp resolved 1 discussion.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @dorimedini-starkware).

[dorimedini-starkware]

@dorimedini-starkware made 1 comment.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @ArielElp).

---

crates/starknet_committer/src/block_committer/commit_test.rs line 60 at r3 (raw file):

Previously, ArielElp wrote…

AFAIU it would require a different assertion line in each layout test, and DB layouts shouldn't affect the resulting roots, this would be a protocol change (OS changes + nodes changes etc.)

layouts won't, but randomness will.
why different assert line? a single assert_debug_eq should do the trick

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).

[github-actions]

Artifacts upload workflows:

• Started at 2026-02-03T15:22:12Z
• Started at 2026-02-03T15:31:01Z
• Started at 2026-02-04T07:04:20Z

[dorimedini-starkware]

@dorimedini-starkware reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp).

---

crates/starknet_committer/src/block_committer/commit_test.rs line 79 at r6 (raw file):

        Self
    }
}

mmmm this isn't enough...?

Suggestion:

impl From<StateRoots> for FactsDbInitialRead {
    fn from(roots: StateRoots) -> Self {
        Self(roots)
    }
}

impl From<StateRoots> for IndexDbReadContext {
    fn from(_roots: StateRoots) -> Self {
        Self
    }
}

---

crates/starknet_committer/src/block_committer/commit_test.rs line 125 at r6 (raw file):

    expected_roots: &Expect,
) where
    Db::InitialReadContext: InitialReadContextFromRoots,

see above

Suggestion:

Db::InitialReadContext: From<StateRoots>,

[ArielElp]

@ArielElp made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware).

---

crates/starknet_committer/src/block_committer/commit_test.rs line 79 at r6 (raw file):

Previously, dorimedini-starkware wrote…

mmmm this isn't enough...?

Done.

---

crates/starknet_committer/src/block_committer/commit_test.rs line 125 at r6 (raw file):

Previously, dorimedini-starkware wrote…

see above

Done.

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).