starknet_committer,starknet_patricia: move db_layout

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_committer: add commit e2e tests #11331
• index layout forest creation tests #11286
• starknet_committer,starknet_patricia: layout-based original tree creation tests #11236
• starknet_committer,starknet_patricia: layout-dependent FilledTree serialization #10988
• starknet_committer,starknet_patricia: add layout for base trait #11566
• starknet_committer,starknet_patricia: add serialization utilities to node layout #10987
• starknet_committer,starknet_patricia: move db_layout #10986 👈 (View in Graphite)
• starknet_committer: add index db #10685
• starknet_committer: abstract original tree creation #10684
• starknet_committer: enrich layout trait to abstract skeleton creation #11182
• starknet_committer: move trie creation logic to trie_traversal #11180
• starknet_committer: group generic layout logic #10852
• starknet_committer,starknet_patricia: remove generic config #10683
• starknet_committer: add index layout nodes #10682
• starknet_committer: add index layout subtree #10919
• starknet_committer: hash leaves of both layouts #10918
• starknet_committer: add index layout leaves #10681
• starknet_committer,starknet_patricia,starknet_patricia_storage: support contract address prefix #10858
• starknet_committer,starknet_patricia: add serde errors #10810
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: layout dependent fetch_nodes #10680
• starknet_committer,starknet_patricia: enrich subtree trait to support fetch nodes #10751
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: make FilledNode generic #10750
• starknet_committer,starknet_os,starknet_patricia: make node data generic #10679
• starknet_committer,starknet_patricia: add deserialization context #10704
• starknet_committer,starknet_patricia,starknet_patricia_storage: add context to prefix and serde #10678
• starknet_committer,starknet_patricia: add subtree trait #10694
• starknet_committer: reorganize facts db files #10677
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[nimrod-starkware]

@nimrod-starkware partially reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp and @yoavGrs).

---

crates/starknet_committer/src/db/index_db/leaves.rs line 58 at r1 (raw file):

        }
    }
}

Why it's no longer a method?
If this is intentional, please rename to trie_type_db_prefix or something more specific

Code quote:

fn db_prefix(trie_type: &TrieType) -> DbKeyPrefix {
    match trie_type {
        TrieType::ContractsTrie => DbKeyPrefix::new((&CONTRACTS_TREE_PREFIX[..]).into()),
        TrieType::ClassesTrie => DbKeyPrefix::new((&CLASSES_TREE_PREFIX[..]).into()),
        TrieType::StorageTrie(contract_address) => {
            let prefix = contract_address.to_bytes_be().to_vec();
            DbKeyPrefix::new(prefix.into())
        }
    }
}

[yoavGrs]

@yoavGrs partially reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp).

---

crates/starknet_committer/src/db/index_db/leaves.rs line 68 at r2 (raw file):

                    db_prefix(key_context)
                }
            }

Not related to this PR.
Why do you take key_context as an argument, instead of defining a type for each trie type?

Code quote:

            impl HasStaticPrefix for $ty {
                type KeyContext = TrieType;
                fn get_static_prefix(key_context: &Self::KeyContext) -> DbKeyPrefix {
                    db_prefix(key_context)
                }
            }

[yoavGrs]

@yoavGrs made 1 comment and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp).

---

crates/starknet_committer/src/db/index_db/leaves.rs line 68 at r2 (raw file):

Previously, yoavGrs wrote…

Not related to this PR.
Why do you take key_context as an argument, instead of defining a type for each trie type?

Discussed.

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: 4 of 7 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @yoavGrs).

---

crates/starknet_committer/src/db/index_db/leaves.rs line 58 at r1 (raw file):

Previously, nimrod-starkware wrote…

Why it's no longer a method?
If this is intentional, please rename to trie_type_db_prefix or something more specific

I moved TrieType to starknet_patricia (it's used in the Layout trait). I don't want to move this impl there since it's specific to index layout, hence this is no longer a method.

Renamed