starknet_committer,starknet_patricia: remove FilledNode impl

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_committer,starknet_patricia: move node_serde to facts db #11644
• starknet_committer: reorganize db modules #11640
• starknet_committer: add commit e2e tests #11331
• index layout forest creation tests #11286
• starknet_committer,starknet_patricia: layout-based original tree creation tests #11236
• starknet_committer: add original tree creation test templates #11715
• starknet_committer,starknet_patricia: layout-dependent db-key separator #11641
• starknet_committer,starknet_patricia: remove FilledNode impl #11637 👈 (View in Graphite)
• starknet_committer: db layout trait #11621
• starknet_committer,starknet_patricia: layout-dependent FilledTree serialization #10988
• starknet_committer,starknet_patricia: refactor key context #11592
• starknet_committer,starknet_patricia: add layout for base trait #11566
• starknet_committer,starknet_patricia: add serialization utilities to node layout #10987
• starknet_committer,starknet_patricia: move db_layout #10986
• starknet_committer: add index db #10685
• starknet_committer: abstract original tree creation #10684
• starknet_committer: enrich layout trait to abstract skeleton creation #11182
• starknet_committer: move trie creation logic to trie_traversal #11180
• starknet_committer: group generic layout logic #10852
• starknet_committer,starknet_patricia: remove generic config #10683
• starknet_committer: add index layout nodes #10682
• starknet_committer: add index layout subtree #10919
• starknet_committer: hash leaves of both layouts #10918
• starknet_committer: add index layout leaves #10681
• starknet_committer,starknet_patricia,starknet_patricia_storage: support contract address prefix #10858
• starknet_committer,starknet_patricia: add serde errors #10810
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: layout dependent fetch_nodes #10680
• starknet_committer,starknet_patricia: enrich subtree trait to support fetch nodes #10751
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: make FilledNode generic #10750
• starknet_committer,starknet_os,starknet_patricia: make node data generic #10679
• starknet_committer,starknet_patricia: add deserialization context #10704
• starknet_committer,starknet_patricia,starknet_patricia_storage: add context to prefix and serde #10678
• starknet_committer,starknet_patricia: add subtree trait #10694
• starknet_committer: reorganize facts db files #10677
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[nimrod-starkware]

@nimrod-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs).

[yoavGrs]

@yoavGrs reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp).

---

crates/starknet_committer_and_os_cli/src/committer_cli/tests/python_tests.rs line 688 at r2 (raw file):

    let suffix = node.hash.0.to_bytes_be();
    node.get_db_key(key_context, &suffix)
}

1. move to above usages
2. make it private, so it's clear that it's an internal util and not a real DB key

Suggestion:

fn db_key<L: Leaf>(
    node: &FactDbFilledNode<L>,
    key_context: &<L as HasStaticPrefix>::KeyContext,
) -> DbKey {
    let suffix = node.hash.0.to_bytes_be();
    node.get_db_key(key_context, &suffix)
}

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware).

---

crates/starknet_committer_and_os_cli/src/committer_cli/tests/python_tests.rs line 688 at r2 (raw file):

Previously, dorimedini-starkware wrote…

1. move to above usages
2. make it private, so it's clear that it's an internal util and not a real DB key

Done. (I think, not sure about 1, I moved it up before the first usage)

[dorimedini-starkware]

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp).

---

crates/starknet_committer_and_os_cli/src/committer_cli/tests/python_tests.rs line 688 at r2 (raw file):

Previously, ArielElp wrote…

Done. (I think, not sure about 1, I moved it up before the first usage)

did you push?

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @nimrod-starkware, and @yoavGrs).

---

crates/starknet_committer_and_os_cli/src/committer_cli/tests/python_tests.rs line 688 at r2 (raw file):

Previously, dorimedini-starkware wrote…

did you push?

Did now