starknet_committer,starknet_patricia: refactor key context

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• starknet_committer,starknet_patricia: move node_serde to facts db #11644
• starknet_committer: reorganize db modules #11640
• starknet_committer: add commit e2e tests #11331
• index layout forest creation tests #11286
• starknet_committer,starknet_patricia: layout-based original tree creation tests #11236
• starknet_committer: add original tree creation test templates #11715
• starknet_committer,starknet_patricia: layout-dependent db-key separator #11641
• starknet_committer,starknet_patricia: remove FilledNode impl #11637
• starknet_committer: db layout trait #11621
• starknet_committer,starknet_patricia: layout-dependent FilledTree serialization #10988
• starknet_committer,starknet_patricia: refactor key context #11592 👈 (View in Graphite)
• starknet_committer,starknet_patricia: add layout for base trait #11566
• starknet_committer,starknet_patricia: add serialization utilities to node layout #10987
• starknet_committer,starknet_patricia: move db_layout #10986
• starknet_committer: add index db #10685
• starknet_committer: abstract original tree creation #10684
• starknet_committer: enrich layout trait to abstract skeleton creation #11182
• starknet_committer: move trie creation logic to trie_traversal #11180
• starknet_committer: group generic layout logic #10852
• starknet_committer,starknet_patricia: remove generic config #10683
• starknet_committer: add index layout nodes #10682
• starknet_committer: add index layout subtree #10919
• starknet_committer: hash leaves of both layouts #10918
• starknet_committer: add index layout leaves #10681
• starknet_committer,starknet_patricia,starknet_patricia_storage: support contract address prefix #10858
• starknet_committer,starknet_patricia: add serde errors #10810
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: layout dependent fetch_nodes #10680
• starknet_committer,starknet_patricia: enrich subtree trait to support fetch nodes #10751
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: make FilledNode generic #10750
• starknet_committer,starknet_os,starknet_patricia: make node data generic #10679
• starknet_committer,starknet_patricia: add deserialization context #10704
• starknet_committer,starknet_patricia,starknet_patricia_storage: add context to prefix and serde #10678
• starknet_committer,starknet_patricia: add subtree trait #10694
• starknet_committer: reorganize facts db files #10677
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[nimrod-starkware]

@nimrod-starkware reviewed 7 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @ArielElp and @yoavGrs).

---

crates/starknet_committer/src/db/index_db/leaves.rs line 49 at r7 (raw file):

/// Set to FIRST_AVAILABLE_PREFIX_FELT + 1
static CLASSES_TREE_PREFIX: LazyLock<[u8; 32]> =
    LazyLock::new(|| (*FIRST_AVAILABLE_PREFIX_FELT + Felt::ONE).to_bytes_be());

WDYT of this? non-blocking

Suggestion:

static CLASSES_TREE_PREFIX: LazyLock<DbKeyPrefix> =
    LazyLock::new(|| DbKeyPrefix((*FIRST_AVAILABLE_PREFIX_FELT + Felt::ONE).to_bytes_be().into()));

---

crates/starknet_committer/src/db/index_db/leaves.rs line 75 at r7 (raw file):

        DbKeyPrefix::new(prefix.into())
    }
}

Suggestion:

impl HasStaticPrefix for IndexLayoutStarknetStorageValue {
    // For the storage tries, the prefix is the contract's address.
    type KeyContext = ContractAddress;
    
    fn get_static_prefix(key_context: &Self::KeyContext) -> DbKeyPrefix {
        let prefix = key_context.to_bytes_be().to_vec();
        DbKeyPrefix::new(prefix.into())
    }
}

[ArielElp]

@ArielElp made 2 comments.
Reviewable status: 16 of 17 files reviewed, 6 unresolved discussions (waiting on @nimrod-starkware and @yoavGrs).

---

crates/starknet_committer/src/db/index_db/leaves.rs line 49 at r7 (raw file):

Previously, nimrod-starkware wrote…

WDYT of this? non-blocking

Can't if I want the borrowed variant of Cow, if the lock is [u8;32] I can send &value to db prefix, but I can't do &prefix.to_bytes_be() in the closure body because it's a temporary value.

---

crates/starknet_committer/src/db/index_db/leaves.rs line 75 at r7 (raw file):

        DbKeyPrefix::new(prefix.into())
    }
}

Added it as a doc for the method, since KeyContext is also ContractAddress for facts layout where the prefix is something else.

[nimrod-starkware]

@nimrod-starkware made 1 comment and resolved 2 discussions.
Reviewable status: 16 of 17 files reviewed, 4 unresolved discussions (waiting on @ArielElp and @yoavGrs).

[yoavGrs]

@yoavGrs reviewed 2 files and all commit messages, and resolved 3 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp and @dorimedini-starkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 17 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp).

---

crates/starknet_committer/src/db/index_db/leaves.rs line 75 at r8 (raw file):

    fn get_static_prefix(key_context: &Self::KeyContext) -> DbKeyPrefix {
        let prefix = key_context.to_bytes_be().to_vec();
        DbKeyPrefix::new(prefix.into())

not for this PR, but, seems like the point of key_context is to define a prefix; so prefixifying should be a method, right?
it's just that key_context.to_bytes_be() seems a bit strange

Suggestion:

        DbKeyPrefix::new(key_context.to_prefix_bytes())

[ArielElp]

@ArielElp resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).