starknet_committer: add original tree creation test templates #11715
+307
−233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2026
|
This change is |
This was referenced Jan 14, 2026
Merged
Contributor
Author
This was referenced Jan 14, 2026
ArielElp
force-pushed
the
ariel/add_skeleton_tree_creation_template
branch
from
14815b7 to
e47d9de
Compare
ArielElp
force-pushed
the
ariel/fix_db_key_separator
branch
from
2bf9147 to
56f611e
Compare
nimrod-starkware
requested changes
Jan 14, 2026
Contributor
nimrod-starkware
left a comment
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @ArielElp and @yoavGrs).
crates/starknet_committer/src/db/create_original_skeleton_tests.rs line 15 at r1 (raw file):
use crate::patricia_merkle_tree::tree::OriginalSkeletonTrieConfig; pub(crate) mod case_helpers {
Why separate module?
Code quote:
pub(crate) mod case_helpers {
ArielElp
force-pushed
the
ariel/fix_db_key_separator
branch
from
56f611e to
957557e
Compare
ArielElp
force-pushed
the
ariel/add_skeleton_tree_creation_template
branch
2 times, most recently
from
095b212 to
ae8e4e3
Compare
ArielElp
force-pushed
the
ariel/fix_db_key_separator
branch
from
957557e to
73f2def
Compare
ArielElp
force-pushed
the
ariel/add_skeleton_tree_creation_template
branch
from
ae8e4e3 to
39a619e
Compare
ArielElp
commented
Jan 18, 2026
Contributor
Author
ArielElp
left a comment
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 1 comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @yoavGrs).
crates/starknet_committer/src/db/create_original_skeleton_tests.rs line 15 at r1 (raw file):
Previously, nimrod-starkware wrote…
Why separate module?
Removed (originally I had issues with the path and the template macro, seems to not be relevant anymore)
ArielElp
force-pushed
the
ariel/fix_db_key_separator
branch
from
73f2def to
93bad1e
Compare
ArielElp
force-pushed
the
ariel/add_skeleton_tree_creation_template
branch
2 times, most recently
from
8ccc27b to
d6eb91e
Compare
ArielElp
force-pushed
the
ariel/fix_db_key_separator
branch
2 times, most recently
from
7427ed8 to
67c930b
Compare
ArielElp
force-pushed
the
ariel/add_skeleton_tree_creation_template
branch
from
d6eb91e to
1b7a549
Compare
ArielElp
force-pushed
the
ariel/fix_db_key_separator
branch
from
67c930b to
e25225d
Compare
ArielElp
force-pushed
the
ariel/add_skeleton_tree_creation_template
branch
2 times, most recently
from
2538ac7 to
fd680df
Compare
ArielElp
force-pushed
the
ariel/fix_db_key_separator
branch
from
2f9e569 to
4e2cfa8
Compare
ArielElp
force-pushed
the
ariel/add_skeleton_tree_creation_template
branch
from
fd680df to
b05aac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.