starknet_committer,starknet_patricia: add layout for base trait

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• starknet_committer,starknet_patricia: move node_serde to facts db #11644
• starknet_committer: reorganize db modules #11640
• starknet_committer: add commit e2e tests #11331
• index layout forest creation tests #11286
• starknet_committer,starknet_patricia: layout-based original tree creation tests #11236
• starknet_committer: add original tree creation test templates #11715
• starknet_committer,starknet_patricia: layout-dependent db-key separator #11641
• starknet_committer,starknet_patricia: remove FilledNode impl #11637
• starknet_committer: db layout trait #11621
• starknet_committer,starknet_patricia: layout-dependent FilledTree serialization #10988
• starknet_committer,starknet_patricia: refactor key context #11592
• starknet_committer,starknet_patricia: add layout for base trait #11566 👈 (View in Graphite)
• starknet_committer,starknet_patricia: add serialization utilities to node layout #10987
• starknet_committer,starknet_patricia: move db_layout #10986
• starknet_committer: add index db #10685
• starknet_committer: abstract original tree creation #10684
• starknet_committer: enrich layout trait to abstract skeleton creation #11182
• starknet_committer: move trie creation logic to trie_traversal #11180
• starknet_committer: group generic layout logic #10852
• starknet_committer,starknet_patricia: remove generic config #10683
• starknet_committer: add index layout nodes #10682
• starknet_committer: add index layout subtree #10919
• starknet_committer: hash leaves of both layouts #10918
• starknet_committer: add index layout leaves #10681
• starknet_committer,starknet_patricia,starknet_patricia_storage: support contract address prefix #10858
• starknet_committer,starknet_patricia: add serde errors #10810
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: layout dependent fetch_nodes #10680
• starknet_committer,starknet_patricia: enrich subtree trait to support fetch nodes #10751
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: make FilledNode generic #10750
• starknet_committer,starknet_os,starknet_patricia: make node data generic #10679
• starknet_committer,starknet_patricia: add deserialization context #10704
• starknet_committer,starknet_patricia,starknet_patricia_storage: add context to prefix and serde #10678
• starknet_committer,starknet_patricia: add subtree trait #10694
• starknet_committer: reorganize facts db files #10677
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArielElp]

@ArielElp made 4 comments.
Reviewable status: 5 of 6 files reviewed, 4 unresolved discussions (waiting on @nimrod-starkware and @yoavGrs).

---

crates/starknet_patricia/src/db_layout.rs line 89 at r2 (raw file):

Previously, yoavGrs wrote…

Why? You can convert to the DB type.

If you only hold NodeLayout, you only know the db type (which is L), the "logical leaf" (or base leaf, however you like to call it) is not part of the NodeLayout trait.

---

crates/starknet_patricia/src/db_layout.rs line 96 at r2 (raw file):

Previously, yoavGrs wrote…

Is it needed?

Nope

---

crates/starknet_patricia/src/db_layout.rs line 96 at r2 (raw file):

Previously, yoavGrs wrote…

Consider a more informative name.
DbLeafConvert?

The agent's name is not bad IMO. It's not converting, it's a layout that grounds both base leaf and dbleaf, e.g. it is the layout of ContractState or layout of StarknetStorageValue.

Some other Claude suggestions:
NodeLayoutForBase
NodeLayoutOverLeaf
TrieLayoutFor

Leaving it open for now

---

crates/starknet_patricia/src/db_layout.rs line 92 at r2 (raw file):

///
/// We require that the BaseLeaf type and its DB representation NodeLayout::DbLeaf are isomorphic.
/// The From<BaseLeaf> conversions are needed to convet incoming modifications, and the

Done.

[yoavGrs]

@yoavGrs reviewed 3 files and all commit messages, and resolved 3 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware).

[nimrod-starkware]

@nimrod-starkware made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

[dorimedini-starkware]

@dorimedini-starkware reviewed 6 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

---

a discussion (no related file):
much better :)

---

crates/starknet_patricia/src/db_layout.rs line 96 at r6 (raw file):

/// leaves. For more details see `create_contracts_trie`, `create_classes_trie`, and
/// `create_storage_tries` in `starknet_committer`.
pub trait NodeLayoutFor<BaseLeaf>: for<'a> NodeLayout<'a, Self::DbLeaf> {

no trait requirements for BaseLeaf?

Code quote:

NodeLayoutFor<BaseLeaf>

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

---

crates/starknet_patricia/src/db_layout.rs line 96 at r6 (raw file):

Previously, dorimedini-starkware wrote…

no trait requirements for BaseLeaf?

No constraints on BaseLeaf here other than conversions with DbLeaf, the Leaf trait is only used from NodeLayout.

[ArielElp]

@ArielElp resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).