Skip to content

Conversation

@ArielElp
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

ArielElp commented Dec 23, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch from af9d87d to fb3bd7a Compare December 23, 2025 13:00
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch from bb2af59 to 32b7f4a Compare December 23, 2025 15:36
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch 2 times, most recently from 3473676 to 9f2ba58 Compare December 24, 2025 08:50
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch from 32b7f4a to 597a809 Compare December 24, 2025 08:50
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch from 9f2ba58 to 3d47fa4 Compare December 24, 2025 11:41
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch from 597a809 to 4487c12 Compare December 24, 2025 11:41
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch from 3d47fa4 to 84d3218 Compare December 24, 2025 11:59
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch 2 times, most recently from 7462cb2 to 83700ae Compare December 31, 2025 15:14
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch 2 times, most recently from 32689fd to f50d827 Compare January 1, 2026 09:34
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch from 83700ae to af7a1c2 Compare January 1, 2026 09:34
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch from f50d827 to b02ddb1 Compare January 1, 2026 12:04
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch from af7a1c2 to c98a897 Compare January 1, 2026 12:04
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch from b02ddb1 to 559cb65 Compare January 1, 2026 13:00
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch from c98a897 to fc7cbdf Compare January 1, 2026 13:00
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch from 559cb65 to e7c745e Compare January 1, 2026 15:29
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch from fc7cbdf to e3dd480 Compare January 1, 2026 15:29
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch from e7c745e to 9a371c7 Compare January 1, 2026 15:33
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch 2 times, most recently from 7b8d6ac to 5613f1a Compare January 4, 2026 11:27
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch from 9a371c7 to 4b852b0 Compare January 4, 2026 11:27
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch from 4b852b0 to 8628308 Compare January 4, 2026 19:12
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch from 5613f1a to 00a550f Compare January 4, 2026 19:12
Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp and @nimrod-starkware).


crates/starknet_patricia/src/db_layout.rs line 55 at r3 (raw file):

    /// Converts `FilledTree` nodes to db objects.
    ///
    /// During the construction of a `FilledTree` we computee the hashes and carry `FilledNode<L,

Do you have code-spell-checker - a VS Code extension?

Suggestion:

compute

@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch from 8628308 to f58109f Compare January 8, 2026 14:15
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch 2 times, most recently from b66f22f to fda3843 Compare January 8, 2026 15:03
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch 2 times, most recently from 2d2e70a to 761794e Compare January 8, 2026 16:32
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch from fda3843 to a25dd7b Compare January 8, 2026 16:32
@ArielElp ArielElp force-pushed the ariel/enrich_layout_for_serialization branch from a25dd7b to efe1bf3 Compare January 8, 2026 19:06
@ArielElp ArielElp force-pushed the ariel/move_layout_to_patricia_storage branch from 761794e to 13d764f Compare January 8, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants