starknet_committer,starknet_patricia: add serialization utilities to node layout

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• starknet_committer,starknet_patricia: move node_serde to facts db #11644
• starknet_committer: reorganize db modules #11640
• starknet_committer: add commit e2e tests #11331
• index layout forest creation tests #11286
• starknet_committer,starknet_patricia: layout-based original tree creation tests #11236
• starknet_committer: add original tree creation test templates #11715
• starknet_committer,starknet_patricia: layout-dependent db-key separator #11641
• starknet_committer,starknet_patricia: remove FilledNode impl #11637
• starknet_committer: db layout trait #11621
• starknet_committer,starknet_patricia: layout-dependent FilledTree serialization #10988
• starknet_committer,starknet_patricia: refactor key context #11592
• starknet_committer,starknet_patricia: add layout for base trait #11566
• starknet_committer,starknet_patricia: add serialization utilities to node layout #10987 👈 (View in Graphite)
• starknet_committer,starknet_patricia: move db_layout #10986
• starknet_committer: add index db #10685
• starknet_committer: abstract original tree creation #10684
• starknet_committer: enrich layout trait to abstract skeleton creation #11182
• starknet_committer: move trie creation logic to trie_traversal #11180
• starknet_committer: group generic layout logic #10852
• starknet_committer,starknet_patricia: remove generic config #10683
• starknet_committer: add index layout nodes #10682
• starknet_committer: add index layout subtree #10919
• starknet_committer: hash leaves of both layouts #10918
• starknet_committer: add index layout leaves #10681
• starknet_committer,starknet_patricia,starknet_patricia_storage: support contract address prefix #10858
• starknet_committer,starknet_patricia: add serde errors #10810
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: layout dependent fetch_nodes #10680
• starknet_committer,starknet_patricia: enrich subtree trait to support fetch nodes #10751
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: make FilledNode generic #10750
• starknet_committer,starknet_os,starknet_patricia: make node data generic #10679
• starknet_committer,starknet_patricia: add deserialization context #10704
• starknet_committer,starknet_patricia,starknet_patricia_storage: add context to prefix and serde #10678
• starknet_committer,starknet_patricia: add subtree trait #10694
• starknet_committer: reorganize facts db files #10677
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

@dorimedini-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp and @yoavGrs).

---

crates/starknet_committer/src/db/facts_db/db.rs line 57 at r5 (raw file):

        let db_filled_node = Self::convert_node_data_and_leaf(filled_node);

        let key = db_filled_node.get_db_key(key_context, &db_filled_node.hash.0.to_bytes_be());

consider implementing a db_key_suffix method on FilledNode type(s),
and use it here and in the below implementation.
in this case the node index will be ignored of course but in general the DB key suffix can depend on it

Suggestion:

db_filled_node.get_db_key(key_context, &db_filled_node.db_key_suffix(node_index));

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp and @yoavGrs).

[ArielElp]

@ArielElp made 2 comments.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware, @nimrod-starkware, and @yoavGrs).

---

crates/starknet_committer/src/db/facts_db/db.rs line 57 at r5 (raw file):

Previously, dorimedini-starkware wrote…

consider implementing a db_key_suffix method on FilledNode type(s),
and use it here and in the below implementation.
in this case the node index will be ignored of course but in general the DB key suffix can depend on it

There is suffix on FilledNode<L, HashOutput> that is actually only used in tests ATM, I think I'll refactor this at the top of the stack (originally I thought of removing suffix altogether, but maybe your suggestion is better)

---

crates/starknet_patricia/src/db_layout.rs line 79 at r4 (raw file):

Previously, nimrod-starkware wrote…

So you convert HashOutput to () in index layout and in facts layout keep as is?

yes (the into call on path_to_bottom was indeed superfluous, removed)

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware and @yoavGrs).

---

crates/starknet_committer/src/db/facts_db/db.rs line 57 at r5 (raw file):

Previously, ArielElp wrote…

There is suffix on FilledNode<L, HashOutput> that is actually only used in tests ATM, I think I'll refactor this at the top of the stack (originally I thought of removing suffix altogether, but maybe your suggestion is better)

ok, so can you add TODOs here and below to use the suffix method?
or, if the PR is already open, let me TAL and I'll "unblock" here

[nimrod-starkware]

@nimrod-starkware reviewed all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

[yoavGrs]

@yoavGrs resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).

[yoavGrs]

@yoavGrs reviewed 2 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp).