blockifier_reexecution: seperate reexecute block from verify correctness

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• blockifier_reexecution: split execute tx logic #10844 : 2 dependent PRs (#10849 , #10855 )
• starknet_os_runner: initialize the crate #10718
• blockifier_reexecution: move files location #10717
• blockifier_reexecution: rename test state reader #10716
• blockifier_reexecution: move reexecute block for testing #10709
• blockifier_reexecution: move write_block reexecution data to file #10708
• blockifier_reexecution: move execute single tx from utils #10707
• blockifier_reexecution: seperate reexecute block from verify correctness #10706 👈 (View in Graphite)
• blockifier_reexecution: move reexecute and verify correctness to trait #10705
• blockifier_reexecution: allow custom chain id #10643
• blockifier_reexecution: use StateReaderAndContractManager in reexecut… #10425
• blockifier_reexecution: impl FetchedCompiledClass for test and offlin… #10330
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[meship-starkware]

@meship-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

---

crates/blockifier_reexecution/src/state_reader/utils.rs line 291 at r1 (raw file):

             diffs do not match."
        );
    }

Why are we only warning in this case?

Code quote:

    if expected_comparable != actual_comparable {
        println!(
            "WARNING: State diff mismatch for block {block_number}. Expected and actual state \
             diffs do not match."
        );
    }

[AvivYossef-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)

---

crates/blockifier_reexecution/src/state_reader/utils.rs line 291 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Why are we only warning in this case?

This is used for writing execution data for later offline test,
not for comparing state diffs.

[meship-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

[graphite-app]

Merge activity

• Dec 11, 1:29 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.