-
Notifications
You must be signed in to change notification settings - Fork 65
blockifier_reexecution: rename test state reader #10716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockifier_reexecution: rename test state reader #10716
Conversation
ddb330f to
f3bc810
Compare
1be4aea to
17e0880
Compare
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meship-starkware reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
crates/blockifier_reexecution/src/state_reader/rpc_https_test.rs line 99 at r1 (raw file):
#[fixture] pub fn test_state_reader() -> RpcStateReader { RpcStateReader {
We already have an RpcStateReader in the Apollo gateway crate. I agree that the blockifier and the gateway are distinctive enough, but as we have so many state readers, it concerns me that having two with the same name will be confusing.
Code quote:
RpcStateReader17e0880 to
77ab248
Compare
f3bc810 to
32b4a67
Compare
32b4a67 to
d99696c
Compare
77ab248 to
b5cd7df
Compare
Merge activity
|
d99696c to
f66e7dc
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @meship-starkware)
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware reviewed 1 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

No description provided.