Skip to content

Conversation

@AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)


crates/blockifier_reexecution/src/state_reader/rpc_https_test.rs line 99 at r1 (raw file):

#[fixture]
pub fn test_state_reader() -> RpcStateReader {
    RpcStateReader {

We already have an RpcStateReader in the Apollo gateway crate. I agree that the blockifier and the gateway are distinctive enough, but as we have so many state readers, it concerns me that having two with the same name will be confusing.

Code quote:

 RpcStateReader

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/move_reexecute_block_for_testing branch from 17e0880 to 77ab248 Compare December 11, 2025 12:38
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/rename_test_state_reader branch from f3bc810 to 32b4a67 Compare December 11, 2025 12:38
@graphite-app graphite-app bot changed the base branch from aviv/move_reexecute_block_for_testing to graphite-base/10716 December 12, 2025 11:40
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/rename_test_state_reader branch from 32b4a67 to d99696c Compare December 12, 2025 12:08
@graphite-app graphite-app bot changed the base branch from graphite-base/10716 to main-v0.14.1 December 12, 2025 12:08
@graphite-app
Copy link

graphite-app bot commented Dec 12, 2025

Merge activity

  • Dec 12, 12:08 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/rename_test_state_reader branch from d99696c to f66e7dc Compare December 13, 2025 11:22
Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @meship-starkware)

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 1 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Dec 13, 2025
Merged via the queue into main-v0.14.1 with commit a14095d Dec 13, 2025
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants