blockifier_reexecution: move execute single tx from utils

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• blockifier_reexecution: split execute tx logic #10844 : 2 dependent PRs (#10849 , #10855 )
• starknet_os_runner: initialize the crate #10718
• blockifier_reexecution: move files location #10717
• blockifier_reexecution: rename test state reader #10716
• blockifier_reexecution: move reexecute block for testing #10709
• blockifier_reexecution: move write_block reexecution data to file #10708
• blockifier_reexecution: move execute single tx from utils #10707 👈 (View in Graphite)
• blockifier_reexecution: seperate reexecute block from verify correctness #10706
• blockifier_reexecution: move reexecute and verify correctness to trait #10705
• blockifier_reexecution: allow custom chain id #10643
• blockifier_reexecution: use StateReaderAndContractManager in reexecut… #10425
• blockifier_reexecution: impl FetchedCompiledClass for test and offlin… #10330
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[meship-starkware]

@meship-starkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)

---

crates/blockifier_reexecution/src/state_reader/test_state_reader.rs line 480 at r1 (raw file):

    /// fetch block context. Does not assert correctness, only prints the execution result.
    pub fn execute_single_transaction(self, tx_input: TransactionInput) -> ReexecutionResult<()> {
        let chain_id = self.next_block_state_reader.chain_id.clone();

Consider moving it into the second arm of the match, as we only use it there.

Code quote:

let chain_id = self.next_block_state_reader.chain_id.clone();

---

crates/blockifier_reexecution/src/state_reader/test_state_reader.rs line 520 at r1 (raw file):

            execution_results.first().expect("Expected exactly one execution result, but got none");

        println!("Execution result: {:?}", res);

Do we want this print here? Wouldn't it be better to log it?

Code quote:

println!("Execution result: {:?}", res);

[meship-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)

---

crates/blockifier_reexecution/src/state_reader/test_state_reader.rs line 520 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Do we want this print here? Wouldn't it be better to log it?

I see that we print in most places in the re-execution crate so I changed it to a quetion rether than blocking commant

[meship-starkware]

@meship-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

[graphite-app]

Merge activity

• Dec 12, 9:54 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[AvivYossef-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)

---

crates/blockifier_reexecution/src/state_reader/test_state_reader.rs line 480 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Consider moving it into the second arm of the match, as we only use it there.

Done

---

crates/blockifier_reexecution/src/state_reader/test_state_reader.rs line 520 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

I see that we print in most places in the re-execution crate so I changed it to a quetion rether than blocking commant

We use it as a CLI tool, not as a library, so we want to print the result.

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)