apollo_gateway: removing usage of gateway trates in rpc_state_reader

[lev-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[lev-starkware]

• blockifier_reexecution: merge rpc_state_reader into state_reader #11717
• blockifier_reexecution: move rpc_state_reader from apollo_gateway into #11628
• apollo_gateway_config: moving RpcStateReaderConfig out of config.rs #11540
• apollo_gateway: removing usage of gateway trates in rpc_state_reader #11539 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArniStarkware]

crates/apollo_gateway/src/rpc_state_reader.rs line 112 at r1 (raw file):

        let block_info = block_header.try_into()?;
        Ok(block_info)
    }

Please delete this function.

It is never used in code (except for testing this function - delete the test as well.).

Code quote:

    pub async fn get_block_info(&self) -> RPCStateReaderResult<BlockInfo> {
        let get_block_params = GetBlockWithTxHashesParams { block_id: self.block_id };
        let reader = self.clone();

        let get_block_with_tx_hashes_result = tokio::task::spawn_blocking(move || {
            reader.send_rpc_request("starknet_getBlockWithTxHashes", get_block_params)
        })
        .await
        .map_err(|e| RPCStateReaderError::InternalError(format!("Join error {}", e)))??;

        let block_header: BlockHeader = serde_json::from_value(get_block_with_tx_hashes_result)
            .map_err(|e| {
                RPCStateReaderError::InternalError(format!("Failed to parse block header {}", e))
            })?;
        let block_info = block_header.try_into()?;
        Ok(block_info)
    }

[ArniStarkware]

crates/apollo_gateway/src/errors.rs line 315 at r1 (raw file):

    StarknetApi(#[from] StarknetApiError),
    #[error("Internal error: {0}")]
    InternalError(String),

Please revert.

Code quote:

    #[error("Internal error: {0}")]
    InternalError(String),

[ArniStarkware]

crates/apollo_gateway/src/rpc_state_reader.rs line 36 at r1 (raw file):

};

pub type StarknetResult<T> = Result<T, StarknetError>;

Delete this?

Code quote:

pub type StarknetResult<T> = Result<T, StarknetError>;

[ArniStarkware]

@ArniStarkware reviewed 3 files and all commit messages, made 1 comment, and resolved 3 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub).

[lev-starkware]

@lev-starkware made 3 comments.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub).

---

crates/apollo_gateway/src/rpc_state_reader.rs line 36 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Delete this?

Done.

---

crates/apollo_gateway/src/rpc_state_reader.rs line 112 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Please delete this function.

It is never used in code (except for testing this function - delete the test as well.).

Done.

---

crates/apollo_gateway/src/errors.rs line 315 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Please revert.

Done.

[ArniStarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub).