blockifier_reexecution: move rpc_state_reader from apollo_gateway into

[lev-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[lev-starkware]

• blockifier_reexecution: merge rpc_state_reader into state_reader #11717
• blockifier_reexecution: move rpc_state_reader from apollo_gateway into #11628 👈 (View in Graphite)
• apollo_gateway_config: moving RpcStateReaderConfig out of config.rs #11540
• apollo_gateway: removing usage of gateway trates in rpc_state_reader #11539
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2026-01-12T12:07:54Z
• Started at 2026-01-12T12:48:17Z
• Started at 2026-01-12T13:07:10Z
• Started at 2026-01-12T13:42:47Z
• Started at 2026-01-12T13:56:14Z
• Started at 2026-01-13T14:26:54Z
• Started at 2026-01-13T15:35:14Z
• Started at 2026-01-13T17:11:04Z
• Started at 2026-01-13T17:11:04Z
• Started at 2026-01-14T12:39:58Z
• Started at 2026-01-15T09:39:36Z
• Started at 2026-01-15T09:39:36Z
• Started at 2026-01-15T09:39:36Z
• Started at 2026-01-15T09:39:36Z
• Started at 2026-01-15T13:13:42Z

[ArniStarkware]

@ArniStarkware reviewed all commit messages.
Reviewable status: 0 of 18 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @noaov1).

[ArniStarkware]

@ArniStarkware partially reviewed 3 files and made 1 comment.
Reviewable status: 3 of 18 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @lev-starkware, and @noaov1).

---

a discussion (no related file):
Should the gateway's Cargo.toml file be affected?

sequencer/crates/apollo_gateway/Cargo.toml

Line 30 in 3f4cacd

apollo_rpc.workspace = true

Please remove all unnecessary dependancies (if any).

[ArniStarkware]

@ArniStarkware reviewed 2 files.
Reviewable status: 5 of 18 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @lev-starkware, and @noaov1).

[ArniStarkware]

@ArniStarkware made 3 comments.
Reviewable status: 5 of 18 files reviewed, 4 unresolved discussions (waiting on @AvivYossef-starkware, @lev-starkware, and @noaov1).

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 43 at r1 (raw file):

use crate::rpc_state_reader::config::RpcStateReaderConfig;
use crate::rpc_state_reader::rpc_objects::{BlockHeader, BlockId, GetBlockWithTxHashesParams};
use crate::rpc_state_reader::rpc_state_reader::RpcStateReader as GatewayRpcStateReader;

This name no longer makes sense.

Code quote:

use crate::rpc_state_reader::rpc_state_reader::RpcStateReader as GatewayRpcStateReader;

---

crates/blockifier_reexecution/Cargo.toml line 18 at r1 (raw file):

apollo_gateway.workspace = true
apollo_gateway_config.workspace = true
apollo_gateway_types.workspace = true

Why is this here? (Saddly, blockifier reexecution was already dependent on apollo_gateway, so this is not a big deal.)

Code quote:

apollo_gateway_types.workspace = true

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader_test.rs line 34 at r1 (raw file):

use crate::rpc_state_reader::config::RpcStateReaderConfig;
use crate::rpc_state_reader::rpc_objects::BlockId;
use crate::rpc_state_reader::rpc_state_reader::RpcStateReader as GatewayRpcStateReader;

This name no longer makes sense.

Code quote:

use crate::rpc_state_reader::rpc_state_reader::RpcStateReader as GatewayRpcStateReader;

[lev-starkware]

@lev-starkware made 3 comments and resolved 3 discussions.
Reviewable status: 5 of 20 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware, @AvivYossef-starkware, and @noaov1).

---

a discussion (no related file):

Previously, ArniStarkware (Arnon Hod) wrote…

Should the gateway's Cargo.toml file be affected?

sequencer/crates/apollo_gateway/Cargo.toml

Line 30 in 3f4cacd

apollo_rpc.workspace = true

Please remove all unnecessary dependancies (if any).

Done. Removed al unnecessary dependences.

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 43 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

This name no longer makes sense.

I leave this to Noa's team

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader_test.rs line 34 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

This name no longer makes sense.

I leave this to Noa's team

[ArniStarkware]

@ArniStarkware resolved 1 discussion.
Reviewable status: 5 of 20 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @noaov1).

[ArniStarkware]

@ArniStarkware reviewed 1 file.
Reviewable status: 6 of 20 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @noaov1).

[ArniStarkware]

@ArniStarkware reviewed 1 file.
Reviewable status: 7 of 20 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @noaov1).

[AvivYossef-starkware]

We need to merge both RpcStateReader into one struct.
you can just merge it, and I'll refactor it later ( you can add TODO with my name )

@AvivYossef-starkware partially reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: 7 of 20 files reviewed, all discussions resolved (waiting on @ArniStarkware and @noaov1).

[ArniStarkware]

crates/blockifier_reexecution/src/errors.rs line 56 at r7 (raw file):

pub fn serde_err_to_state_err(err: SerdeError) -> StateError {
    StateError::StateReadError(format!("Failed to parse rpc result {:?}", err.to_string()))
}

If we are cleaning things up.

Suggestion:

// Converts a serde error to the error type of the state reader.
fn serde_err_to_state_err(err: SerdeError) -> StateError {
    StateError::StateReadError(format!("Failed to parse rpc result {:?}", err.to_string()))
}

[ArniStarkware]

@ArniStarkware reviewed 2 files.
Reviewable status: 4 of 20 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @lev-starkware, and @noaov1).

[ArniStarkware]

@ArniStarkware reviewed 1 file.
Reviewable status: 5 of 20 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @lev-starkware, and @noaov1).

[ArniStarkware]

@ArniStarkware partially reviewed 7 files and made 2 comments.
Reviewable status: 12 of 20 files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware, @lev-starkware, and @noaov1).

---

crates/blockifier_reexecution/src/rpc_state_reader/rpc_state_reader_test.rs line 20 at r7 (raw file):

    RpcSuccessResponse,
};
use crate::rpc_state_reader::rpc_state_reader::RpcStateReader;

I am a bit sad that we have: rpc_state_reader::rpc_state_reader. Will this be cleaned up soon?

Code quote:

use crate::rpc_state_reader::rpc_state_reader::RpcStateReader;

---

crates/blockifier_reexecution/src/rpc_state_reader/mod.rs line 4 at r7 (raw file):

pub mod rpc_objects;
#[allow(clippy::module_inception)]
pub mod rpc_state_reader;

Please explain this error.
@AvivYossef-starkware are you fine with that? This is a bit ugly in my opinion (and causes lines like:

use crate::rpc_state_reader::rpc_state_reader::RpcStateReader;

which has the word rpc_state_reader appear three times).

Code quote:

#[allow(clippy::module_inception)]
pub mod rpc_state_reader;