Skip to content

apollo_gateway_config: moving RpcStateReaderConfig out of config.rs #11540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lev-starkware merged 1 commit into from
Jan 13, 2026
Merged

apollo_gateway_config: moving RpcStateReaderConfig out of config.rs #11540

lev-starkware merged 1 commit into from
Jan 13, 2026

Conversation

@lev-starkware
Copy link
Contributor

@lev-starkware lev-starkware commented Jan 8, 2026

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Jan 8, 2026

This change is Reviewable

@lev-starkware Graphite App
Copy link
Contributor Author

lev-starkware commented Jan 8, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lev-starkware lev-starkware mentioned this pull request Jan 8, 2026
Merged
@lev-starkware lev-starkware marked this pull request as ready for review January 8, 2026 15:56
@lev-starkware lev-starkware marked this pull request as draft January 8, 2026 15:57
@lev-starkware lev-starkware marked this pull request as ready for review January 8, 2026 15:59
ArniStarkware
ArniStarkware approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArniStarkware reviewed 10 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub).

@lev-starkware lev-starkware force-pushed the 01-08-apollo_gateway_config_moving_rpcstatereaderconfig_out_of_config.rs branch from 37cd83a to 615b58b Compare January 12, 2026 12:07
@lev-starkware lev-starkware force-pushed the 01-08-apollo_gateway_removing_usage_of_gateway_trates_in_rpc_state_reader branch from 3c34489 to 631fd8f Compare January 12, 2026 12:07
@lev-starkware lev-starkware mentioned this pull request Jan 12, 2026
Open
ArniStarkware
ArniStarkware approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ArniStarkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub).

@lev-starkware lev-starkware changed the base branch from 01-08-apollo_gateway_removing_usage_of_gateway_trates_in_rpc_state_reader to main January 13, 2026 14:26
@graphite-app
Copy link

graphite-app bot commented Jan 13, 2026 •
edited
Loading

Merge activity

  • Jan 13, 2:26 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Jan 13, 2:26 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@lev-starkware lev-starkware force-pushed the 01-08-apollo_gateway_config_moving_rpcstatereaderconfig_out_of_config.rs branch from 615b58b to 97cf2fd Compare January 13, 2026 15:35
lev-starkware
lev-starkware commented Jan 13, 2026
View reviewed changes
Copy link
Contributor Author

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lev-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub).

ArniStarkware
ArniStarkware approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArniStarkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub).

@lev-starkware lev-starkware added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 22f7d5c Jan 13, 2026
21 of 26 checks passed
@lev-starkware lev-starkware mentioned this pull request Jan 14, 2026
Open
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ArniStarkware ArniStarkware ArniStarkware approved these changes

@TzahiTaub TzahiTaub Awaiting requested review from TzahiTaub

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lev-starkware @reviewable-StarkWare @ArniStarkware