apollo_http_server: turn off unsupported tx version test

[einat-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[einat-starkware]

• apollo_batcher: delete proof validator and move proof verification to transaction converter #11421 : 2 dependent PRs (#11141 , #11157 )
• apollo_proof_manager: add proof manager client to the transaction converter #11044
• apollo_node: integrate proof manager server #11043
• apollo_node: integrate proof manager client into node #11042
• apollo_proof_manager: add metrics file #11041
• apollo_http_server: turn off unsupported tx version test #11625 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[meship-starkware]

@meship-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @einat-starkware and @noaov1).

---

crates/apollo_http_server/src/http_server_test.rs line 304 at r1 (raw file):

//     let starknet_error = serde_json::from_str::<StarknetError>(&serialized_err).unwrap();
//     assert_eq!(starknet_error, expected_err);
// }

Instate of commenting add #[ignore] + TODO

Suggestion:

// TODO(Einat): turn test back on when port issue is fixed.
#[ignore] 
// #[rstest]
// #[case::missing_version(
//     0,
//     None,
//     StarknetError {
//         code: StarknetErrorCode::KnownErrorCode(KnownStarknetErrorCode::MalformedRequest),
//         message: "Missing version field".to_string(),
//     }
// )]
// #[case::bad_version(
//     1,
//     Some("bad version"),
//     StarknetError {
//         code: StarknetErrorCode::KnownErrorCode(KnownStarknetErrorCode::MalformedRequest),
//         message: "Version field is not a valid hex string: badversion".to_string(), //Note:
// whitespaces are removed when parsing malformed tx jsons     }
// )]
// #[case::old_version(2, Some("0x1"), StarknetError {
//             code: StarknetErrorCode::KnownErrorCode(
//                 KnownStarknetErrorCode::InvalidTransactionVersion,
//             ),
//             message: "Transaction version 1 is not supported. Supported versions: [3]."
//                 .to_string(),
//         },
// )]
// #[case::newer_version(3, Some("0x4"), StarknetError {
//                 code: StarknetErrorCode::KnownErrorCode(
//                     KnownStarknetErrorCode::InvalidTransactionVersion,
//                 ),
//                 message: "Transaction version 4 is not supported. Supported versions: [3]."
//                     .to_string(),
//             }
// )]
// #[tokio::test]
// async fn test_unsupported_tx_version(
//     #[case] index: u16,
//     #[case] version: Option<&str>,
//     #[case] expected_err: StarknetError,
// ) {
//     // Set the tx version to the given version.
//     let mut tx_json =
//         TransactionSerialization(serde_json::to_value(deprecated_gateway_invoke_tx()).unwrap());
//     let as_object = tx_json.0.as_object_mut().unwrap();
//     if let Some(version) = version {
//         as_object.insert("version".to_string(), Value::String(version.to_string())).unwrap();
//     } else {
//         as_object.remove("version").unwrap();
//     }

//     let mock_gateway_client = MockGatewayClient::new();
//     let mock_config_manager_client = MockConfigManagerClient::new();

//     let http_client =
//         add_tx_http_client(mock_config_manager_client, mock_gateway_client, 9 + index).await;

//     let serialized_err =
//         http_client.assert_add_tx_error(tx_json, reqwest::StatusCode::BAD_REQUEST).await;
//     let starknet_error = serde_json::from_str::<StarknetError>(&serialized_err).unwrap();
//     assert_eq!(starknet_error, expected_err);
// }

[einat-starkware]

@einat-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1).

---

crates/apollo_http_server/src/http_server_test.rs line 304 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Instate of commenting add #[ignore] + TODO

Done.

[meship-starkware]

@meship-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1).