test(starknet_os): deprecated syscall hint consistency test

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• test(starknet_os): deprecated syscall hint strings test #6992
• test(starknet_os): deprecated syscall hint consistency test #6988 👈 (View in Graphite)
• test(starknet_os): hint consistency test with local program objects #6931
• feat(starknet_os): remove the program from the OS runner inputs #5877
• feat(apollo_starknet_os_program): add test contracts, add dumper in CLI #5946 : 1 other dependent PR (#6069 )
• feat(apollo_starknet_os_program): compile programs asynchronously #5945
• feat(apollo_starknet_os_program): add command to dump aggregator program #5943 : 1 other dependent PR (#5944 )
• feat(apollo_starknet_os_program): add aggregator program + program hash(es) #5937
• test(ci): prepare apollo_starknet_os_program for publishing #5933
• feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876
• feat(apollo_starknet_os_program): add fixer for program hash test #5875
• feat(apollo_starknet_os_program): define and implement static ProgramHash #5874
• feat(apollo_starknet_os_program): define and implement static Program #5873
• fix(ci): properly install python deps, in CI and docker #5902 : 1 other dependent PR (#6266 )
• feat(apollo_infra_utils): better cairo0 compiler checks #5921
• chore(apollo_infra_utils): explicit instructions in verify_cairo0_compiler_deps #5872
• chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils #5871
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[amosStarkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 140 at r1 (raw file):

                !matches!(
                    selector,
                    // As the new and deprecated syscall selector enums are the same enum,

whyyy

Code quote:

// As the new and deprecated syscall selector enums are the same enum,

---

crates/starknet_os/src/hints/enum_definition_test.rs line 181 at r1 (raw file):

         syscall hints. Converted selectors: {converted_selectors:#?}, hints: \
         {deprecated_syscall_hints:#?}"
    );

you're verifying that every deprecated sycall has exactly one hint - I was thinking of verifying that DeprecatedSyscallHint contains exactly the syscall hints used by the OS.
If we know every syscall will have exactly one hint, and the hint string will not change, I guess that's ok. is this the case?
if yes - consider explaining this in a comment

Code quote:

    assert_eq!(
        deprecated_syscall_selectors.len(),
        deprecated_syscall_hints.len(),
        "The number of deprecated syscall selectors does not match the number of deprecated \
         syscall hints. Selectors: {deprecated_syscall_selectors:#?}, hints: \
         {deprecated_syscall_hints:#?}",
    );

    let converted_selectors: HashSet<DeprecatedSyscallHint> = deprecated_syscall_selectors
        .iter()
        .map(|selector| DeprecatedSyscallHint::try_from(*selector).unwrap())
        .collect();
    assert_eq!(
        converted_selectors,
        deprecated_syscall_hints.iter().cloned().collect(),
        "The deprecated syscall selectors, converted to hints, do not match the deprecated \
         syscall hints. Converted selectors: {converted_selectors:#?}, hints: \
         {deprecated_syscall_hints:#?}"
    );

[amosStarkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 140 at r1 (raw file):

Previously, amosStarkware wrote…

whyyy

lol yes... bummer

---

crates/starknet_os/src/hints/enum_definition_test.rs line 181 at r1 (raw file):

Previously, amosStarkware wrote…

you're verifying that every deprecated sycall has exactly one hint - I was thinking of verifying that DeprecatedSyscallHint contains exactly the syscall hints used by the OS.
If we know every syscall will have exactly one hint, and the hint string will not change, I guess that's ok. is this the case?
if yes - consider explaining this in a comment

hint strings are tested in the next PR, is that what you meant?

[amosStarkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 181 at r1 (raw file):

Previously, dorimedini-starkware wrote…

hint strings are tested in the next PR, is that what you meant?

yes

[graphite-app]

Merge activity

• Jun 8, 10:30 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.