-
Notifications
You must be signed in to change notification settings - Fork 65
test(starknet_os): deprecated syscall hint strings test #6992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(starknet_os): deprecated syscall hint strings test #6992
Conversation
|
Benchmark movements: No major performance changes detected. |
amosStarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/starknet_os/src/hints/enum_definition_test.rs line 190 at r1 (raw file):
/// Tests that the deprecated syscall hint strings match the strings in compiled Cairo0 contracts. #[test] fn test_deprecated_syscall_hint_strings() {
I think your first idea (adding a contract with all deprecated syscalls) was better - talking in slack.
Code quote:
/// Tests that the deprecated syscall hint strings match the strings in compiled Cairo0 contracts.
#[test]
fn test_deprecated_syscall_hint_strings() {
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)
crates/starknet_os/src/hints/enum_definition_test.rs line 190 at r1 (raw file):
Previously, amosStarkware wrote…
I think your first idea (adding a contract with all deprecated syscalls) was better - talking in slack.
Done. added a comment
fe31033 to
6507218
Compare
amosStarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
fc9c69e to
a9db393
Compare
6507218 to
8880b6d
Compare
a9db393 to
4ed5535
Compare
8880b6d to
8efa204
Compare
4ed5535 to
eddb322
Compare
8efa204 to
74c3ba1
Compare
eddb322 to
e534e35
Compare
74c3ba1 to
830f724
Compare
amosStarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
e534e35 to
015c853
Compare
830f724 to
6d3a3e7
Compare
Merge activity
|

No description provided.