Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

Copy link
Collaborator Author

dorimedini-starkware commented Jun 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

Benchmark movements: No major performance changes detected.

Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_os/src/hints/enum_definition_test.rs line 190 at r1 (raw file):

/// Tests that the deprecated syscall hint strings match the strings in compiled Cairo0 contracts.
#[test]
fn test_deprecated_syscall_hint_strings() {

I think your first idea (adding a contract with all deprecated syscalls) was better - talking in slack.

Code quote:

/// Tests that the deprecated syscall hint strings match the strings in compiled Cairo0 contracts.
#[test]
fn test_deprecated_syscall_hint_strings() {

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)


crates/starknet_os/src/hints/enum_definition_test.rs line 190 at r1 (raw file):

Previously, amosStarkware wrote…

I think your first idea (adding a contract with all deprecated syscalls) was better - talking in slack.

Done. added a comment

@dorimedini-starkware dorimedini-starkware force-pushed the 06-05-test_starknet_os_deprecated_syscall_hint_strings_test branch from fe31033 to 6507218 Compare June 5, 2025 11:22
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 06-05-test_starknet_os_deprecated_syscall_hint_consistency_test branch from fc9c69e to a9db393 Compare June 5, 2025 13:03
@dorimedini-starkware dorimedini-starkware force-pushed the 06-05-test_starknet_os_deprecated_syscall_hint_strings_test branch from 6507218 to 8880b6d Compare June 5, 2025 13:03
@dorimedini-starkware dorimedini-starkware force-pushed the 06-05-test_starknet_os_deprecated_syscall_hint_consistency_test branch from a9db393 to 4ed5535 Compare June 5, 2025 13:52
@dorimedini-starkware dorimedini-starkware force-pushed the 06-05-test_starknet_os_deprecated_syscall_hint_strings_test branch from 8880b6d to 8efa204 Compare June 5, 2025 13:53
@dorimedini-starkware dorimedini-starkware force-pushed the 06-05-test_starknet_os_deprecated_syscall_hint_consistency_test branch from 4ed5535 to eddb322 Compare June 5, 2025 17:08
@dorimedini-starkware dorimedini-starkware force-pushed the 06-05-test_starknet_os_deprecated_syscall_hint_strings_test branch from 8efa204 to 74c3ba1 Compare June 5, 2025 17:09
@dorimedini-starkware dorimedini-starkware force-pushed the 06-05-test_starknet_os_deprecated_syscall_hint_consistency_test branch from eddb322 to e534e35 Compare June 8, 2025 08:57
@dorimedini-starkware dorimedini-starkware force-pushed the 06-05-test_starknet_os_deprecated_syscall_hint_strings_test branch from 74c3ba1 to 830f724 Compare June 8, 2025 08:57
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 06-05-test_starknet_os_deprecated_syscall_hint_consistency_test branch from e534e35 to 015c853 Compare June 8, 2025 10:30
@dorimedini-starkware dorimedini-starkware changed the base branch from 06-05-test_starknet_os_deprecated_syscall_hint_consistency_test to main-v0.14.0 June 8, 2025 11:15
@dorimedini-starkware dorimedini-starkware force-pushed the 06-05-test_starknet_os_deprecated_syscall_hint_strings_test branch from 830f724 to 6d3a3e7 Compare June 8, 2025 11:15
@graphite-app
Copy link

graphite-app bot commented Jun 8, 2025

Merge activity

  • Jun 8, 11:16 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jun 8, 2025
Merged via the queue into main-v0.14.0 with commit 5eff506 Jun 8, 2025
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants