test(starknet_os): hint consistency test with local program objects

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• test(starknet_os): deprecated syscall hint strings test #6992
• test(starknet_os): deprecated syscall hint consistency test #6988
• test(starknet_os): hint consistency test with local program objects #6931 👈 (View in Graphite)
• feat(starknet_os): remove the program from the OS runner inputs #5877
• feat(apollo_starknet_os_program): add test contracts, add dumper in CLI #5946 : 1 other dependent PR (#6069 )
• feat(apollo_starknet_os_program): compile programs asynchronously #5945
• feat(apollo_starknet_os_program): add command to dump aggregator program #5943 : 1 other dependent PR (#5944 )
• feat(apollo_starknet_os_program): add aggregator program + program hash(es) #5937
• test(ci): prepare apollo_starknet_os_program for publishing #5933
• feat(starknet_committer_and_os_cli): add command to dump the OS compiled program to file #5876
• feat(apollo_starknet_os_program): add fixer for program hash test #5875
• feat(apollo_starknet_os_program): define and implement static ProgramHash #5874
• feat(apollo_starknet_os_program): define and implement static Program #5873
• fix(ci): properly install python deps, in CI and docker #5902 : 1 other dependent PR (#6266 )
• feat(apollo_infra_utils): better cairo0 compiler checks #5921
• chore(apollo_infra_utils): explicit instructions in verify_cairo0_compiler_deps #5872
• chore(apollo_infra_utils,blockifier_test_utils): move verify_cairo0_compiler_deps to infra_utils #5871
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Benchmark movements: No major performance changes detected.

[TzahiTaub]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 21 at r1 (raw file):

}

fn unknown_hints_for_program(program: &Program, filter: &HashSet<&str>) -> HashSet<String> {

Please doc (this arg specifically), and consider renaming

Suggestion:

ignored_hints: &HashSet<&str>

---

crates/starknet_os/src/hints/enum_definition_test.rs line 27 at r1 (raw file):

        .iter_hints()
        .map(|hint| hint.code.clone())
        .filter(|hint_str| !filter.contains(hint_str.as_str()))

Can you use a filter_map and avoide the hint code cloning for the filter set?

Code quote:

        .map(|hint| hint.code.clone())
        .filter(|hint_str| !filter.contains(hint_str.as_str()))

---

crates/starknet_committer_and_os_cli/src/os_cli/tests/python_tests.rs line 97 at r1 (raw file):

}

fn vm_hints() -> HashSet<&'static str> {

Delete this as well in your TODO (maybe move it upwards so it will be together with the rest of the code for deletion).

Code quote:

fn vm_hints() -> HashSet<&'static str> {

[dorimedini-starkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware and @TzahiTaub)

---

crates/starknet_committer_and_os_cli/src/os_cli/tests/python_tests.rs line 97 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Delete this as well in your TODO (maybe move it upwards so it will be together with the rest of the code for deletion).

stale

---

crates/starknet_os/src/hints/enum_definition_test.rs line 21 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Please doc (this arg specifically), and consider renaming

went with a static set instead

---

a discussion (no related file):
py side

[amosStarkware]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware and @TzahiTaub)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 67 at r2 (raw file):

#[test]
fn test_all_hints_are_known() {

maybe we should also verify that all hints are used?

Code quote:

fn test_all_hints_are_known() {

[TzahiTaub]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @nimrod-starkware)

[dorimedini-starkware]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @nimrod-starkware, and @TzahiTaub)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 67 at r2 (raw file):

Previously, amosStarkware wrote…

maybe we should also verify that all hints are used?

Done.

[amosStarkware]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 88 at r3 (raw file):

        .filter(|hint| {
            // Skip syscalls; they do not appear in the OS code.
            !matches!(hint, AllHints::DeprecatedSyscallHint(_))

This means the deprecated syscalls aren't tested in either test, right?
isn't that a problem?

Code quote:

!matches!(hint, AllHints::DeprecatedSyscallHint(_))

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @nimrod-starkware)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 88 at r3 (raw file):

Previously, amosStarkware wrote…

This means the deprecated syscalls aren't tested in either test, right?
isn't that a problem?

how would you test them without a flow test?
we could add a test that compiles a cairo0 contract with all syscalls somewhere in it, and then add it's hints to the list of known hints; is that what you mean?

[amosStarkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @nimrod-starkware)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 88 at r3 (raw file):

Previously, dorimedini-starkware wrote…

how would you test them without a flow test?
we could add a test that compiles a cairo0 contract with all syscalls somewhere in it, and then add it's hints to the list of known hints; is that what you mean?

that sounds good. add a TODO?

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @nimrod-starkware)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 88 at r3 (raw file):

Previously, amosStarkware wrote…

that sounds good. add a TODO?

part 1
part 2

[amosStarkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 68 at r4 (raw file):

#[test]
fn test_all_hints_are_known() {

comment here & in test_all_hints_are_used that these tests don't include deprecated syscall hints? non blocking

Code quote:

fn test_all_hints_are_known() {

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

---

crates/starknet_os/src/hints/enum_definition_test.rs line 68 at r4 (raw file):

Previously, amosStarkware wrote…

comment here & in test_all_hints_are_used that these tests don't include deprecated syscall hints? non blocking

this test does not care, and the second test includes a comment + there will be explicit tests for the syscalls, so I'm good with how things are

[github-actions]

Artifacts upload workflows:

• Started at 2025-06-05T13:02:54Z