Skip to content

refactor: use stwo_air_utils for par air generation#50

Merged
Alon-Ti merged 1 commit intomainfrom
alont/par-gen
Mar 1, 2025
Merged

refactor: use stwo_air_utils for par air generation#50
Alon-Ti merged 1 commit intomainfrom
alont/par-gen

Conversation

@Alon-Ti
Copy link
Contributor

@Alon-Ti Alon-Ti commented Feb 18, 2025

  • follows current design in stwo-cairo for this opcode.
  • inline write_trace_row
  • add LookupData that wraps InteractionClaimGenerator fields, which
    also holds n_calls.
  • fix edge cases if input is smaller than LOG_N_LANES

This change is Reviewable

- follows current design in stwo-cairo for this opcode.
- inline write_trace_row
- add LookupData that wraps InteractionClaimGenerator fields, which
  also holds n_calls.
- fix edge cases if input is smaller than LOG_N_LANES
@Alon-Ti Alon-Ti marked this pull request as ready for review February 18, 2025 12:59
Copy link
Contributor Author

Alon-Ti commented Feb 18, 2025

Copy link

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)


crates/prover/src/cairo_air/mod.rs line 140 at r1 (raw file):

        //         )
        //     })
        //     .collect_vec();

do we want to just remove all of these?

Code quote:

        // let ret_components = cairo_claim
        //     .ret
        //     .iter()
        //     .zip(interaction_claim.ret.iter())
        //     .map(|(claim, interaction_claim)| {
        //         ret_opcode::Component::new(
        //             tree_span_provider,
        //             ret_opcode::Eval {
        //                 claim: claim.clone(),
        //                 memory_lookup: interaction_elements.addr_to_value_lookup.clone(),
        //                 state_lookup: interaction_claim.addr_to_value.clone(),
        //             },
        //             interaction_claim.logup_sums,
        //         )
        //     })
        //     .collect_vec();

@Alon-Ti Alon-Ti merged commit 69d1822 into main Mar 1, 2025
8 checks passed
Copy link
Contributor Author

Alon-Ti commented Mar 1, 2025

Merge activity

  • Mar 1, 8:58 AM EST: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants