refactor: use stwo_air_utils for par air generation#50
Merged
Conversation
- follows current design in stwo-cairo for this opcode. - inline write_trace_row - add LookupData that wraps InteractionClaimGenerator fields, which also holds n_calls. - fix edge cases if input is smaller than LOG_N_LANES
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 18, 2025
giladchase
approved these changes
Feb 27, 2025
giladchase
left a comment
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)
crates/prover/src/cairo_air/mod.rs line 140 at r1 (raw file):
// ) // }) // .collect_vec();
do we want to just remove all of these?
Code quote:
// let ret_components = cairo_claim
// .ret
// .iter()
// .zip(interaction_claim.ret.iter())
// .map(|(claim, interaction_claim)| {
// ret_opcode::Component::new(
// tree_span_provider,
// ret_opcode::Eval {
// claim: claim.clone(),
// memory_lookup: interaction_elements.addr_to_value_lookup.clone(),
// state_lookup: interaction_claim.addr_to_value.clone(),
// },
// interaction_claim.logup_sums,
// )
// })
// .collect_vec();
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

also holds n_calls.
This change is