Skip to content

Parallelized add_mul trace gen.#51

Merged
Alon-Ti merged 1 commit intomainfrom
alont/par-addmul
Mar 1, 2025
Merged

Parallelized add_mul trace gen.#51
Alon-Ti merged 1 commit intomainfrom
alont/par-addmul

Conversation

@Alon-Ti
Copy link
Contributor

@Alon-Ti Alon-Ti commented Feb 18, 2025

This change is Reviewable

@Alon-Ti Alon-Ti marked this pull request as ready for review February 18, 2025 13:20
@Alon-Ti Alon-Ti requested a review from giladchase February 18, 2025 13:20
Copy link
Contributor Author

Alon-Ti commented Feb 18, 2025

Copy link

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)


crates/prover/src/components/add_mul_opcode/prover.rs line 191 at r1 (raw file):

// Add / Mul trace row:
// | State (3) | flags (5) | offsets (3) | addrs (3) | values (3 * 4) |

Can we keep this docs? i liked it 🥺

Code quote:

// Add / Mul trace row:
// | State (3) | flags (5) | offsets (3) | addrs (3) | values (3 * 4) |

@Alon-Ti Alon-Ti changed the base branch from alont/par-gen to graphite-base/51 March 1, 2025 13:58
@Alon-Ti Alon-Ti force-pushed the alont/par-addmul branch from c18b4a3 to 878d5d5 Compare March 1, 2025 13:58
@Alon-Ti Alon-Ti changed the base branch from graphite-base/51 to main March 1, 2025 13:59
@Alon-Ti Alon-Ti force-pushed the alont/par-addmul branch from 878d5d5 to 3c402f1 Compare March 1, 2025 13:59
@Alon-Ti Alon-Ti merged commit a7e4c08 into main Mar 1, 2025
5 checks passed
Copy link
Contributor Author

Alon-Ti commented Mar 1, 2025

Merge activity

  • Mar 1, 9:02 AM EST: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants